Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the API redirect issue on the same port during Google authentication #119

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fixes the API redirect issue on the same port during Google authentication #119

merged 1 commit into from
Jun 27, 2024

Conversation

aimedivin
Copy link
Contributor

What does this PR do?

This PR resolves the API redirect issue during Google authentication

Description of Task to be completed?

  • Ensure the client receives the appropriate response after successful authentication
  • Correct the redirection URLto ensure it points to the correct client URL

How should this be manually tested?

git clone https://github.com/atlp-rwanda/knights-ecomm-be.git
cd knights-ecomm-be
git checkout fix-google-auth
npm i
npm run dev

@aimedivin aimedivin force-pushed the fix-google-auth branch 4 times, most recently from 93c6157 to 3291418 Compare June 24, 2024 13:06
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9645905911

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 91.803%
Totals Coverage Status
Change from base Build 9599474307: -0.06%
Covered Lines: 1512
Relevant Lines: 1584
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9646994773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 91.803%
Totals Coverage Status
Change from base Build 9599474307: -0.06%
Covered Lines: 1512
Relevant Lines: 1584
💛 - Coveralls

@maxCastro1 maxCastro1 force-pushed the fix-google-auth branch 3 times, most recently from 9e863c7 to caa5e2d Compare June 25, 2024 07:53
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9660578895

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.839%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/productServices/getCategories.ts 7 9 77.78%
Totals Coverage Status
Change from base Build 9599474307: -0.02%
Covered Lines: 1513
Relevant Lines: 1586
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9660578104

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.839%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/productServices/getCategories.ts 7 9 77.78%
Totals Coverage Status
Change from base Build 9599474307: -0.02%
Covered Lines: 1513
Relevant Lines: 1586
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9695871310

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.763%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/productServices/getCategories.ts 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
src/services/productServices/listAllProductsService.ts 1 93.33%
Totals Coverage Status
Change from base Build 9599474307: -0.1%
Covered Lines: 1509
Relevant Lines: 1583
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9699732127

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.766%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/productServices/getCategories.ts 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
src/services/productServices/listAllProductsService.ts 1 93.33%
Totals Coverage Status
Change from base Build 9599474307: -0.1%
Covered Lines: 1510
Relevant Lines: 1584
💛 - Coveralls

@aimedivin aimedivin requested a review from elijahladdie June 27, 2024 18:14
@aimedivin
fix(google-auth): resolve API redirect issue on same port during goog…
db4db9b 
…le authentication

- ensure correct redirect to client URL
- send appropriate response to client

fix(google-auth): resolve API redirect issue on same port during google authentication
- ensure correct redirect to client URL
- send appropriate response to client
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9702382183

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.766%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/productServices/getCategories.ts 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
src/services/productServices/listAllProductsService.ts 1 93.33%
Totals Coverage Status
Change from base Build 9599474307: -0.1%
Covered Lines: 1510
Relevant Lines: 1584
💛 - Coveralls

faid-terence
faid-terence approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved !!

@faid-terence faid-terence merged commit 616c297 into develop Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxCastro1 maxCastro1 maxCastro1 left review comments

@faid-terence faid-terence faid-terence approved these changes

@elijahladdie elijahladdie elijahladdie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aimedivin @coveralls @maxCastro1 @elijahladdie @faid-terence