Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit-add-retriving-users #122

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fit-add-retriving-users #122

merged 1 commit into from
Jul 12, 2024

Conversation

Calebgisa72
Copy link
Contributor

This branch adds two new routes: getting all users and getting a single user.

@Calebgisa72 Calebgisa72 requested a review from faid-terence July 12, 2024 10:26
@Calebgisa72 Calebgisa72 force-pushed the fix-users-retrival branch 2 times, most recently from 686857c to 047adc1 Compare July 12, 2024 11:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9907061726

Details

  • 10 of 21 (47.62%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 91.232%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/userServices/getAllUsers.ts 4 9 44.44%
src/services/userServices/getUserById.ts 4 10 40.0%
Totals Coverage Status
Change from base Build 9882667888: -0.5%
Covered Lines: 1518
Relevant Lines: 1603

💛 - Coveralls

Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved @Calebgisa72 !
Nice Work !!

@faid-terence faid-terence merged commit b5c68f1 into develop Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants