Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-add-notification-sound #127

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

Calebgisa72
Copy link
Contributor

@Calebgisa72 Calebgisa72 commented Jul 24, 2024

This PR adds a sound property to an object sent by the websocket when new notification arrives.

@Calebgisa72 Calebgisa72 requested a review from faid-terence July 24, 2024 08:50
@coveralls
Copy link

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10073906326

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 90.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/orderServices/updateOrderService.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/services/orderServices/updateOrderService.ts 1 88.89%
Totals Coverage Status
Change from base Build 10029952787: 0.0%
Covered Lines: 1547
Relevant Lines: 1651

💛 - Coveralls

@Calebgisa72 Calebgisa72 force-pushed the feat-add-notification-sound branch from c21cb0d to cad3134 Compare July 24, 2024 09:14
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Calebgisa72 !

@faid-terence faid-terence merged commit a465b74 into develop Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants