Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logger to Object Detection node and Detector Plugins #72

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

jasmeet0915
Copy link
Contributor


Name: Added logger to Object Detection node and Detector Plugins

Description 📖

This PR adds a logger member to the ObjectDetection Node, DetectorBase, and Plugins. All the scripts are updated for logging and default log directory is also set in run_devel.sh

Fixes #67

Type of change 📜

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires testing before it can be merged into the main/development branch

@jasmeet0915 jasmeet0915 requested a review from sudo-deep March 3, 2024 14:44
@sudo-deep
Copy link

Node logs not being written to file in ROS_LOGS_DIR, unknown ROS issue.
Rest of the changes are functional.

@sudo-deep sudo-deep merged commit c457b2c into develop Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants