Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:タグの取得のN + 1問題の解決 #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat:タグの取得のN + 1問題の解決 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions go/livestream_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,15 @@ func reserveLivestreamHandler(c echo.Context) error {
}
}

var (
livestreamModel = &LivestreamModel{
UserID: int64(userID),
Title: req.Title,
Description: req.Description,
PlaylistUrl: req.PlaylistUrl,
ThumbnailUrl: req.ThumbnailUrl,
StartAt: req.StartAt,
EndAt: req.EndAt,
}
)
livestreamModel := &LivestreamModel{
UserID: int64(userID),
Title: req.Title,
Description: req.Description,
PlaylistUrl: req.PlaylistUrl,
ThumbnailUrl: req.ThumbnailUrl,
StartAt: req.StartAt,
EndAt: req.EndAt,
}

if _, err := tx.ExecContext(ctx, "UPDATE reservation_slots SET slot = slot - 1 WHERE start_at >= ? AND end_at <= ?", req.StartAt, req.EndAt); err != nil {
return echo.NewHTTPError(http.StatusInternalServerError, "failed to update reservation_slot: "+err.Error())
Expand Down Expand Up @@ -499,16 +497,19 @@ func fillLivestreamResponse(ctx context.Context, tx *sqlx.Tx, livestreamModel Li
return Livestream{}, err
}

tags := make([]Tag, len(livestreamTagModels))
var tagIDs []int64
for i := range livestreamTagModels {
tagModel := TagModel{}
if err := tx.GetContext(ctx, &tagModel, "SELECT * FROM tags WHERE id = ?", livestreamTagModels[i].TagID); err != nil {
tagIDs = append(tagIDs, livestreamTagModels[i].TagID)
}
tags := make([]Tag, len(livestreamTagModels))
if len(tagIDs) > 0 {
query, params, err := sqlx.In("SELECT * FROM tags WHERE id IN (?)", tagIDs)
if err != nil {
return Livestream{}, err
}

tags[i] = Tag{
ID: tagModel.ID,
Name: tagModel.Name,
query = tx.Rebind(query)
if err := tx.SelectContext(ctx, &tags, query, params...); err != nil {
return Livestream{}, err
}
}

Expand Down