Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pool memory management #70

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Conversation

attackgoat
Copy link
Owner

@attackgoat attackgoat commented Jan 28, 2024

The pool types have the ability to grow and eventually use up all available resources.

This can be reproduced using the MSAA example or any other code which leases resources dependent on the swapchain size and then continuously resizing the window in order to generate many requests for resources with different sizes.

This is related to but not necessarily the entire fix for #69.

Additionally, there should be a new pool type which focuses on using the least possible memory overall.

  • Review and improve existing Pool code
  • Add basic memory management functions
  • Add new FifoPool implementation
  • Add bucket size configuration to all pool types
  • Ensure documentation and relevant examples are in place

@attackgoat attackgoat added the enhancement New feature or request label Jan 28, 2024
@attackgoat attackgoat linked an issue Jan 28, 2024 that may be closed by this pull request
@attackgoat attackgoat marked this pull request as ready for review January 30, 2024 04:19
@attackgoat attackgoat merged commit 43293d4 into master Jan 30, 2024
3 checks passed
@attackgoat attackgoat deleted the 69-window-resizing-lags-in-v092 branch January 30, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window resizing lags in v0.9.2
1 participant