Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ResolverPool send to allow for resolve/submit on a different thread. #79

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

DGriffin91
Copy link
Contributor

Would it be possible to allow for resolve/submit on a different thread?

I'm currently using this to get some initial pipelined rendering working where the graph is built on one thread and then resolved/submitted on another.

Here's a screenshot from tracy with before and after.

image

@attackgoat
Copy link
Owner

I think Send is a reasonable constraint here, and it looks like you're saving 3ms!

This could also be accomplished by just keeping a Pool type on the worker thread, it's safe to create and drop at any time.

@attackgoat attackgoat merged commit 564883b into attackgoat:master Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants