fix(browser-history): decode fragment #50

bigopon · 2019-04-21T06:14:44Z

Without decoding fragment, URL with special character will trigger _loadUrl twice.

CLAassistant · 2019-04-21T06:14:52Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bigopon
❌ AureliaEffect
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

EisenbergEffect · 2019-04-21T15:00:38Z

src/browser-history.ts

@@ -39,7 +37,7 @@ export class BrowserHistory extends History {
    super();

    this._isActive = false;
-    this._checkUrlCallback = this._checkUrl.bind(this);
+    this._checkUrl = this._checkUrl.bind(this);


Any reason why this change was made?

The old way is less bundle size friendly

Doesn't this change the behavior though, since the same property is representing both a bound and unbound function?

Yes, it changes instance behavior. Anyone who wants prototype fn can still get it via BrowserHistory.prototype._checkUrl.

AureliaEffect and others added 3 commits April 20, 2019 15:58

Merge branch 'develop'

ee8d7fa

chore(all): add latest build artifacts

4cf18cf

fix(browser-history): decode fragment, add tests

957532d

EisenbergEffect reviewed Apr 21, 2019

View reviewed changes

EisenbergEffect merged commit a0f80d2 into aurelia:develop Apr 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(browser-history): decode fragment #50

fix(browser-history): decode fragment #50

bigopon commented Apr 21, 2019 •

edited

Loading

CLAassistant commented Apr 21, 2019

EisenbergEffect Apr 21, 2019

bigopon Apr 21, 2019

EisenbergEffect Apr 21, 2019

bigopon Apr 21, 2019

fix(browser-history): decode fragment #50

fix(browser-history): decode fragment #50

Conversation

bigopon commented Apr 21, 2019 • edited Loading

CLAassistant commented Apr 21, 2019

EisenbergEffect Apr 21, 2019

Choose a reason for hiding this comment

bigopon Apr 21, 2019

Choose a reason for hiding this comment

EisenbergEffect Apr 21, 2019

Choose a reason for hiding this comment

bigopon Apr 21, 2019

Choose a reason for hiding this comment

bigopon commented Apr 21, 2019 •

edited

Loading