Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update unit tests to latest #110

Merged
merged 3 commits into from
Aug 10, 2024
Merged

feat: update unit tests to latest #110

merged 3 commits into from
Aug 10, 2024

Conversation

3cp
Copy link
Member

@3cp 3cp commented Aug 10, 2024

Removed htmlhint (way outdated, caused node depreccation warning). May add markuplint in future.
Removed less. Low usage, and very easy for users to add to their project if they need.
Removed browser-do+jasmine, browser-do+mocha, since almost nobody uses browser-do. Just provide jest/vitest for unit tests.

@3cp 3cp force-pushed the unit-tests branch 4 times, most recently from b9d366d to 4cc6a57 Compare August 10, 2024 07:14
Removed htmlhint (way outdated, caused node depreccation warning).
May add markuplint in future.
Removed less. Low usage, and very easy for users to add to their
project if they need.
Removed browser-do+jasmine, browser-do+mocha, since almost nobody
uses browser-do. Just provide jest/vitest for unit tests.
@3cp 3cp marked this pull request as ready for review August 10, 2024 07:58
@3cp 3cp requested a review from bigopon August 10, 2024 07:58
Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @3cp , only a few small comments for discussion.

common/src/main.ext__if_app Show resolved Hide resolved
dumber/gulpfile.js Outdated Show resolved Hide resolved
plugin-min/test__if_not_no-unit-tests/hello-world.spec.ext Outdated Show resolved Hide resolved
Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @3cp , only few cleanup comments.

common/test__if_not_no-unit-tests/setup.ext Outdated Show resolved Hide resolved
app-min/test__if_not_no-unit-tests/my-app.spec.ext Outdated Show resolved Hide resolved
app-min/test__if_not_no-unit-tests/my-app.spec.ext Outdated Show resolved Hide resolved
@3cp
Copy link
Member Author

3cp commented Aug 10, 2024

Ready for review.

Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @3cp 🙏

@3cp 3cp merged commit ea72d5a into master Aug 10, 2024
28 checks passed
@3cp 3cp deleted the unit-tests branch August 10, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants