-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update unit tests to latest #110
Conversation
b9d366d
to
4cc6a57
Compare
Removed htmlhint (way outdated, caused node depreccation warning). May add markuplint in future. Removed less. Low usage, and very easy for users to add to their project if they need. Removed browser-do+jasmine, browser-do+mocha, since almost nobody uses browser-do. Just provide jest/vitest for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @3cp , only a few small comments for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @3cp , only few cleanup comments.
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @3cp 🙏
Removed htmlhint (way outdated, caused node depreccation warning). May add markuplint in future.
Removed less. Low usage, and very easy for users to add to their project if they need.
Removed browser-do+jasmine, browser-do+mocha, since almost nobody uses browser-do. Just provide jest/vitest for unit tests.