rfc(error): improve timeout error stack trace for waitFor

aurelia · Sep 19, 2019 · 584c806 · 584c806
1 parent bbef100
commit 584c806
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/wait.ts b/src/wait.ts
@@ -34,11 +34,14 @@ export function waitFor<T>(getter: () => T, options: {
     return new Promise(rs => setTimeout(rs, options.interval)).then(wait);
   }
 
+  // We generate the error here to capture the stack trace, but we will only throw it if it times out
+  const timeoutError = new Error(options.present ? 'Element not found' : 'Element not removed');
+
   return Promise.race([
     new Promise(
       (_, rj) => setTimeout(() => {
         timedOut = true;
-        rj(new Error(options.present ? 'Element not found' : 'Element not removed'));
+        rj(timeoutError);
       }, options.timeout)
     ),
     wait()