feat(validation-controller): revalidateErrors for object or property #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice 👍 - could you rename the arguments I understand why you probably didn't do that initially- to avoid changing the method too much but in this case I think it's important to keep the public APIs consistent. Thanks! |
…r an object's property
manuel-guilbault
force-pushed
the
revalidateErrors-for-property
branch
from
a2b7833 to
35c05ea
Compare
|
👍 done! |
|
@jdanyow Can this be closed? It looks like it was merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for what seems to me like a good enough fix for #279. It is easy to implement
a 'dependsOn' binding behavior calling this method to revalidate the errors of a specific
property.