Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v2 config of buf #188

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use v2 config of buf #188

wants to merge 3 commits into from

Conversation

tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Aug 21, 2024

Description

Something that I noticed as I was working in this repo. v2 lets us specify inputs, which means that you can invoke buf generate without any args and get the desired behavior.

This is the successor to #185

Changes

  • Use v2 of buf config

Testing

See that everything goes green and that you can run buf generate locally.

@tstirrat15 tstirrat15 requested a review from a team August 21, 2024 16:57
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's up but this does not work for me locally. When I switch back to v1, it works. It fails to run with both ./buf.gen.yaml and buf generate. Not the case with v1.

./buf.gen.yaml

Failure: :3:1 unknown field "version", expected one of [file]
   3 | version: "v2"
   3 | ^

:4:1 unknown field "inputs", expected one of [file]
   4 | inputs:
   4 | ^

:6:1 unknown field "plugins", expected one of [file]
   6 | plugins:
   6 | ^
buf generate

Failure: plugin mypy_grpc: exec: "mypy_grpc": executable file not found in $PATH

I confirmed that mypy and mypy_grpc were installed

@tstirrat15
Copy link
Contributor Author

I'll have a look

@vroldanbet
Copy link
Contributor

@tstirrat15 I still get the same errors, just now with the prefixes 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants