Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraints on historic version #200

Closed

Conversation

tstirrat15
Copy link
Contributor

I'm mostly opening this to validate that our checks succeed on this release cut.

@tstirrat15 tstirrat15 requested a review from a team September 9, 2024 21:39
@tstirrat15
Copy link
Contributor Author

I'm not entirely sure what's going on here.

The general problem we're running into (or at least my understanding of it) is that the protobuf version available to the runtime needs to be the same as the protobuf version used to generate the code, or else there may be mismatches at runtime. That seems to be roughly what's causing the test failures.

I think there's a mismatch between the grpc_python_lib installed by brew in my environment and the protobuf version being listed by the library. I've got a TODO item for myself to get this lib using the python-supplied plugins rather than those supplied by buf for the purposes of generation, but that'd go on HEAD rather than here.

Which is to say that I think there's a way to get this working but I haven't yet figured it out.

@tstirrat15
Copy link
Contributor Author

I ran into version issues when I attempted to regenerate the client. I'm going to assume that the client should still work with the relaxed restrictions, since semver says there are no breaking changes, and cut a release on this branch for testing.

@tstirrat15
Copy link
Contributor Author

This passed the user's CI and was released in https://github.com/authzed/authzed-py/releases/tag/v0.14.1. I'm going to close this as merging it wouldn't mean much.

@tstirrat15 tstirrat15 closed this Sep 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant