Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InsecureClient to stub file #202

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add InsecureClient to stub file #202

merged 1 commit into from
Sep 10, 2024

Conversation

mateenkasim
Copy link
Contributor

Adds InsecureClient to __init__.pyi so that VSCode's Pylance can get the type-hinting for it right

@mateenkasim mateenkasim requested a review from a team September 10, 2024 19:38
tstirrat15
tstirrat15 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I didn't think about it when I was setting up that client.

@tstirrat15 tstirrat15 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into authzed:main with commit a5e4e3a Sep 10, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@mateenkasim mateenkasim deleted the insecure-client-stub branch September 10, 2024 20:29
@tstirrat15
Copy link
Contributor

I'll get a release cut as soon as #203 is merged.

@tstirrat15
Copy link
Contributor

This was released in v0.18.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateenkasim @tstirrat15