Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ChunkContainer.hpp #152

Merged
merged 8 commits into from
Nov 30, 2024
Merged

Update ChunkContainer.hpp #152

merged 8 commits into from
Nov 30, 2024

Conversation

rghouzra
Copy link
Contributor

@rghouzra rghouzra commented Nov 28, 2024 •
edited by auto-differentiation-dev
Loading

Description

This PR fixes the ChunkContainer for correct move semantics.

@xcelerit-team
Copy link
Collaborator

xcelerit-team commented Nov 28, 2024 •
edited
Loading

Thanks for submitting. The fixes for the move operations are clearly needed.

The modifications of the check_space method are in partial conflict with the currently open PR #150, which is just about to get merged. That will also fix the build issues.

I suggest we leave this one open until #150 is merged, then rebase and finish it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Test Results

    29 files      29 suites   1h 52m 50s ⏱️
 1 451 tests  1 451 ✅ 0 💤 0 ❌
53 955 runs  53 955 ✅ 0 💤 0 ❌

Results for commit 3deb47e.

♻️ This comment has been updated with latest results.

@auto-differentiation-dev
Copy link
Collaborator

Please try to update your branch after merging #150 .

@boring-cyborg boring-cyborg bot added benchmarks Run benchmark workflow src labels Nov 29, 2024
@rghouzra
Copy link
Contributor Author

Please try to update your branch after merging #150 .

done

@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12089653451

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.961%
Totals Coverage Status
Change from base Build 12087690056: 0.002%
Covered Lines: 2762
Relevant Lines: 2791
💛 - Coveralls

@auto-differentiation-dev auto-differentiation-dev merged commit 8597b4a into auto-differentiation:main Nov 30, 2024
110 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Nov 30, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auto-differentiation-dev auto-differentiation-dev auto-differentiation-dev approved these changes

Assignees
No one assigned
Labels
benchmarks Run benchmark workflow src
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rghouzra @xcelerit-team @auto-differentiation-dev @coveralls