Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hypot math function #93

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

auto-differentiation-dev
Copy link
Collaborator

Description

This adds the standard math function hypot (introduced in C++11), which allows calculating
sqrt(x*x + y*y) without potential overflow for intermediate results.

This function is then used in complex abs, fixing an issue when infinity was returned for
large numbers.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2024

Coverage Status

coverage: 98.56% (+0.005%) from 98.555%
when pulling 70ff612 on feature/hypot-function
into 415838a on main.

Copy link

github-actions bot commented Jan 9, 2024

Test Results

    29 files  ±  0      29 suites  ±0   12m 6s ⏱️ +17s
 1 271 tests +  5   1 271 ✅ +  5  0 💤 ±0  0 ❌ ±0 
36 859 runs  +145  36 859 ✅ +145  0 💤 ±0  0 ❌ ±0 

Results for commit 70ff612. ± Comparison against base commit 415838a.

♻️ This comment has been updated with latest results.

@auto-differentiation-dev auto-differentiation-dev merged commit 9447d88 into main Jan 10, 2024
114 checks passed
@auto-differentiation-dev auto-differentiation-dev deleted the feature/hypot-function branch March 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants