Remove unit settings from distance nodedefs inputs #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying both "unittype" and "unit" in nodedefs breaks something, and the conversion between units does not happen when switching them in Viewer. This change remove "units" from nodedefs inputs of type "distance". Note that "unit" remains for angles. Removing it causes an error (likely a bug) at load time. "Unrecognized destination unit: meter" Seems like materialX tries to convert degrees to meters. While things seem to be still a bit buggy for angles, this seem to currently work at least for distences. Viewer doesn not allow to change the angle unit, so it can't be tested in that environment. It's likely that angle will fail as distances were failing when unit was present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying both "unittype" and "unit" in nodedefs breaks something, and the conversion between units does not happen when switching them in Viewer.
This change remove "units" from nodedefs inputs of type "distance".
Note that "unit" remains for angles. Removing it causes an error (likely a bug) at load time. "Unrecognized destination unit: meter"
Seems like materialX tries to convert degrees to meters.
While things seem to be still a bit buggy for angles, this seem to currently work at least for distances. Viewer doesn't not allow to change the angle unit, so it can't be tested in that environment. It's likely that angle will fail as distances were failing when unit was present.