Allow Bundle Spec's with version 1.0

automationbroker · Jun 28, 2018 · ee734ce · ee734ce
1 parent b505505
commit ee734ce
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/bundle/version.go b/bundle/version.go
@@ -54,6 +54,10 @@ func (s *Spec) ValidateVersion() bool {
 func (s *Spec) checkVersion() bool {
 	specSemver, err := semver.NewVersion(s.Version)
 	if err != nil {
+		if s.Version == "1.0" {
+			log.Warningf("Spec version is not semver compatable")
+			return true
+		}
 		log.Errorf("Failed to init semver - %v", err)
 		return false
 	}

diff --git a/bundle/version_test.go b/bundle/version_test.go
@@ -35,10 +35,10 @@ func TestValidateVersion(t *testing.T) {
 	testSpec.Runtime = 2
 	ft.True(t, testSpec.ValidateVersion())
 
-	// Test Invalid Spec Versions
-	testSpec.Version = "1.0" // not valid semver
-	ft.False(t, testSpec.ValidateVersion())
+	testSpec.Version = "1.0" // Deprecated Spec Version
+	ft.True(t, testSpec.ValidateVersion())
 
+	// Test Invalid Spec Versions
 	testSpec.Version = "0.9.0" // less than min
 	ft.False(t, testSpec.ValidateVersion())