Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding public URLs for tabular benchmark #121

Open
wants to merge 102 commits into
base: development
Choose a base branch
from

Conversation

Neeratyoy
Copy link
Collaborator

Added the figshare public URLs. Couldn't successfully test it though.

Tried the following:

from hpobench.benchmarks.ml_mmfb import TabularBenchmark
benchmark = TabularBenchmark(data_dir=None, model="svm", task_id=10101)

Failed with the error TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' at L98 of hpobench/util/data_manager.py

Neeratyoy added 30 commits June 23, 2021 20:32
PhMueller and others added 5 commits August 19, 2021 14:54
@Neeratyoy Neeratyoy requested a review from PhMueller August 19, 2021 19:47
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #121 (6394521) into development (1a789b7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #121      +/-   ##
===============================================
+ Coverage        44.34%   44.37%   +0.02%     
===============================================
  Files               41       41              
  Lines             2336     2337       +1     
===============================================
+ Hits              1036     1037       +1     
  Misses            1300     1300              
Impacted Files Coverage Δ
hpobench/util/data_manager.py 57.50% <100.00%> (+0.09%) ⬆️

Base automatically changed from PR_Multi-fidelity-tabular-benchmarks to development September 1, 2021 07:44
@Neeratyoy
Copy link
Collaborator Author

@PhMueller
this branch is now pointing to dev with the other big PR being merged
we could merge this directly to dev?
and for future updates to the URLs I could just have another PR doing so?

@Neeratyoy
Copy link
Collaborator Author

@KEggensperger updated with changes for CRC rerunning, involving the cost and optimization budgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants