increase default parameters

[DaMandal0rian]

PR Type

enhancement

---

Description

• Increased the default values for --in-peers, --out-peers, --dsn-in-connections, --dsn-out-connections, --dsn-pending-in-connections, and --dsn-pending-out-connections from 1000 to 2000 in create_bootstrap_node_compose_file.sh and create_bootstrap_node_evm_compose_file.sh.
• Updated traefik image version from v2.10 to v2.11.6 in create_domain_node_compose_file.sh and create_rpc_node_compose_file.sh.
• Increased the default value for --rpc-max-connections from 10000 to 15000 in create_domain_node_compose_file.sh and create_rpc_node_compose_file.sh.

---

Changes walkthrough 📝

Relevant files

Enhancement

create_bootstrap_node_compose_file.sh Increase peer and connection limits in bootstrap node compose script templates/scripts/create_bootstrap_node_compose_file.sh Increased the default values for --in-peers, --out-peers, --dsn-in-connections, --dsn-out-connections, --dsn-pending-in-connections, and --dsn-pending-out-connections from 1000 to 2000. +6/-6      create_bootstrap_node_evm_compose_file.sh Increase peer and connection limits in bootstrap node EVM compose script templates/scripts/create_bootstrap_node_evm_compose_file.sh Increased the default values for --in-peers, --out-peers, --dsn-in-connections, --dsn-out-connections, --dsn-pending-in-connections, and --dsn-pending-out-connections from 1000 to 2000. +6/-6      create_domain_node_compose_file.sh Update traefik version and increase RPC max connections in domain node compose script templates/scripts/create_domain_node_compose_file.sh Updated traefik image version from v2.10 to v2.11.6. Increased the default value for --rpc-max-connections from 10000 to 15000. +2/-2      create_rpc_node_compose_file.sh Update traefik version and increase RPC max connections in RPC node compose script templates/scripts/create_rpc_node_compose_file.sh Updated traefik image version from v2.10 to v2.11.6. Increased the default value for --rpc-max-connections from 10000 to 15000. +2/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Possible Performance Impact: The increase in default values for peer and connection limits might have implications on system performance and resource utilization. It would be beneficial to ensure that these changes are tested under load to verify that the system can handle the increased numbers without degradation. Configuration Validation: Ensure that the new default values do not conflict with other system settings or exceed any built-in limits of the software components.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Replace hardcoded peer and connection limits with configurable environment variables Consider using environment variables or a configuration file to manage the peer and connection limits. This approach enhances flexibility and maintainability, allowing adjustments without modifying the script directly. templates/scripts/create_bootstrap_node_compose_file.sh [147-152] -"--in-peers", "2000", -"--out-peers", "2000", -"--dsn-in-connections", "2000", -"--dsn-out-connections", "2000", -"--dsn-pending-in-connections", "2000", -"--dsn-pending-out-connections", "2000", +"--in-peers", "$IN_PEERS", +"--out-peers", "$OUT_PEERS", +"--dsn-in-connections", "$DSN_IN_CONNECTIONS", +"--dsn-out-connections", "$DSN_OUT_CONNECTIONS", +"--dsn-pending-in-connections", "$DSN_PENDING_IN_CONNECTIONS", +"--dsn-pending-out-connections", "$DSN_PENDING_OUT_CONNECTIONS", Suggestion importance[1-10]: 8 Why: Using environment variables for configuration enhances maintainability and flexibility, allowing changes without modifying the script directly. This is a significant improvement for managing configurations.	8
Best practice	Use an environment variable for the Traefik image version to enhance maintainability Update the image version for Traefik in a configuration file or use an environment variable to manage versioning dynamically. This change will make version updates easier and more consistent across different scripts. templates/scripts/create_domain_node_compose_file.sh [50] -image: traefik:v2.11.6 +image: "$TRAEFIK_VERSION" Suggestion importance[1-10]: 7 Why: Managing the Traefik image version through an environment variable improves maintainability and consistency across different scripts, although it is a minor enhancement.	7
Possible issue	Validate and warn if the RPC maximum connections setting exceeds recommended limits Consider validating the increase in RPC maximum connections to ensure it does not exceed the server's capacity, potentially using a configuration check or a warning log if the value is too high. templates/scripts/create_domain_node_compose_file.sh [118] -"--rpc-max-connections", "15000" +if [ $RPC_MAX_CONNECTIONS -gt 15000 ]; then + echo "Warning: RPC max connections exceed recommended limit." +fi +"--rpc-max-connections", "$RPC_MAX_CONNECTIONS" Suggestion importance[1-10]: 6 Why: Adding a validation check for RPC maximum connections can prevent potential server overloads, enhancing robustness. However, the implementation might need refinement to integrate seamlessly.	6
Performance	Dynamically adjust RPC maximum connections based on server load Implement a mechanism to adjust the RPC maximum connections based on the load or time of day to optimize resource usage and prevent server overload. templates/scripts/create_rpc_node_compose_file.sh [115] -"--rpc-max-connections", "15000" +"--rpc-max-connections", "$(adjust_rpc_connections_based_on_load)" Suggestion importance[1-10]: 5 Why: Dynamically adjusting RPC connections based on load can optimize resource usage, but the suggestion lacks details on how to implement the adjustment mechanism, making it less practical without further context.	5