This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
config
command #294base: main
Are you sure you want to change the base?
Add
config
command #294Changes from 14 commits
95d3996
4f08f9c
93fed0b
15c4f9e
313b7bf
7f558ef
b56e71a
b9f9bcb
68f413a
a9826fa
ef9072f
8ea0009
bb4a85f
a82110f
fd985c5
689b061
fb6c772
208e297
9b2539e
96e408b
3caa3c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if this fails? We are left with some data in old directory and some data in new one. Which means after this happen, user won't be able to use pulsar and have to fix the situation by hand.
I would like to have atomic move implemented here. Either we move everything or we move nothing.