-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build-and-test-differential): if unnecessary, completely ignore cuda build #9520
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9520 +/- ##
=======================================
Coverage 29.48% 29.48%
=======================================
Files 1443 1443
Lines 108683 108683
Branches 41540 41540
=======================================
Hits 32044 32044
Misses 73519 73519
Partials 3120 3120
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b9beeb6
to
ffac751
Compare
…cuda build Signed-off-by: Y.Hisaki <[email protected]>
ffac751
to
2f87b82
Compare
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
matrix: | ||
rosdistro: | ||
- humble | ||
container-suffix: | ||
- "" | ||
- -cuda | ||
include: | ||
- rosdistro: humble | ||
container: ghcr.io/autowarefoundation/autoware:universe-devel | ||
container-suffix: "" | ||
build-depends-repos: build_depends.repos | ||
- container-suffix: -cuda | ||
runner: codebuild-autoware-us-east-1-${{ github.run_id }}-${{ github.run_attempt }}-ubuntu-7.0-large | ||
build-pre-command: taskset --cpu-list 0-5 | ||
- container-suffix: "" | ||
runner: ubuntu-latest | ||
build-pre-command: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are splitting build-and-test-differential and build-and-test-differential-cuda as a job, then we probably don't have to use matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the separation build-and-test-differential action made its maintenance more complex and the action logs harder to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitsudome-r
Matrix has been removed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review. I see your point. Could you provide more details on how splitting build-and-test-differential
makes maintenance more complex or action logs harder to read? I'll consider solutions to these issues!
Alternatively, if you have other ideas for addressing the problems described in the motivation, I'd like to hear them!
Signed-off-by: Y.Hisaki <[email protected]>
Description
Motivation
Previously, we configured PRs without CUDA-related changes to skip the build-and-test step. However, even just pulling the CUDA image or using the self-hosted runner can sometimes cause errors, which may block PRs unrelated to CUDA. This PR prevents pulling the CUDA image and using the self-hosted runner for PRs that are unrelated to CUDA.
Modified/Added jobs
cuda_build
outputtag:build-and-test-differential
label is not presentcuda_build=false
)ubuntu-latest
runner andghcr.io/autowarefoundation/autoware:universe-devel
containercuda_build=true
)Important
If this PR is merged, all of the jobs listed above need to be set as required. Since skipped jobs are treated as "Success", this should work correctly.
Behavior details
If
tag:build-and-test-differential
does not exist (Github Actions) → Failprepare-build-and-test-differential
When a package unrelated to cuda is modified (Github Actions)
When a package related to cuda is changed (Github Actions)
If both are changed (Github Actions)
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.