Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_multi_object_tracker): measure latency with latest detection update time #9533

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Dec 2, 2024

Description

Fixing the pipeline latency measurement point.
The latest updated detection time will be used for the latency measurement.

  1. startMeasurementTime uses latest time rather than oldest time
  2. object_oldest_time is renamed to object_earliest_time
  3. onMessage method is removed since it is not callback function anymore.

Related links

Parent Issue: #9428

  • Link

How was this PR tested?

Screenshot from 2024-12-02 13-43-06

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Dec 2, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 29.49%. Comparing base (557a8b5) to head (a888295).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lti_object_tracker/src/processor/input_manager.cpp 0.00% 9 Missing ⚠️
...i_object_tracker/src/multi_object_tracker_node.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9533      +/-   ##
==========================================
- Coverage   29.49%   29.49%   -0.01%     
==========================================
  Files        1443     1443              
  Lines      108648   108654       +6     
  Branches    41537    41540       +3     
==========================================
  Hits        32047    32047              
- Misses      73479    73485       +6     
  Partials     3122     3122              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.50% <ø> (+<0.01%) ⬆️ Carriedforward from 557a8b5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review December 2, 2024 05:43
@cyn-liu cyn-liu self-requested a review December 2, 2024 06:33
@cyn-liu
Copy link
Contributor

cyn-liu commented Dec 3, 2024

I have tested this PR and the result looks consistent with expectations.
#9428 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Calculation Method of "latency_ms" in Node "multi_object_tracker" Seems Unreasonable
2 participants