Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync files #5505

Closed
wants to merge 2 commits into from
Closed

chore: sync files #5505

wants to merge 2 commits into from

Conversation

awf-autoware-bot[bot]
Copy link
Contributor

@awf-autoware-bot awf-autoware-bot bot commented Nov 28, 2024

Skipped

Added

  • .github/workflows/spell-check-daily.yaml

Changed

  • .github/pull_request_template.md
  • .pre-commit-config.yaml

Not changed

  • .github/ISSUE_TEMPLATE/bug.yaml
  • .github/ISSUE_TEMPLATE/config.yml
  • .github/ISSUE_TEMPLATE/task.yaml
  • .github/dependabot.yaml
  • .github/stale.yml
  • .github/workflows/cancel-previous-workflows.yaml
  • .github/workflows/comment-on-pr.yaml
  • .github/workflows/github-release.yaml
  • .github/workflows/pre-commit-optional.yaml
  • .github/workflows/pre-commit-optional-autoupdate.yaml
  • .github/workflows/pre-commit-autoupdate.yaml
  • .github/workflows/semantic-pull-request.yaml
  • .github/workflows/spell-check-differential.yaml
  • .github/workflows/sync-files.yaml
  • .clang-format
  • .clang-tidy
  • .markdown-link-check.json
  • .markdownlint.yaml
  • .pre-commit-config-optional.yaml
  • .prettierignore
  • .prettierrc.yaml
  • .yamllint.yaml
  • CODE_OF_CONDUCT.md
  • CONTRIBUTING.md
  • CPPLINT.cfg
  • DISCLAIMER.md
  • LICENSE
  • setup.cfg

Deleted

Not found

Copy link

github-actions bot commented Nov 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@awf-autoware-bot awf-autoware-bot bot force-pushed the sync-files branch 2 times, most recently from 8c67e99 to 9c3a257 Compare November 28, 2024 21:05
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@xmfcx xmfcx added the tag:run-health-check Run health-check label Nov 28, 2024
@xmfcx xmfcx self-requested a review November 28, 2024 21:21
@xmfcx
Copy link
Contributor

xmfcx commented Nov 28, 2024

Related:

This PR updates updates the pre-commit ci configs from current autoware.universe. (Coming from the https://github.com/autowarefoundation/sync-file-templates repository).

https://github.com/autowarefoundation/autoware_core_universe_prototype/pull/5/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R93

I don't see a reason to exclude .svg files from pre-commit, it makes svg files more readable. I've looked for why it was excluded but it has been like this since first 5th PR to this repository. Most of the changes are just reformatted svg files.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 28, 2024

See:

For detailed explanations.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 28, 2024

Ready for review ✅

@awf-autoware-bot awf-autoware-bot bot closed this Nov 29, 2024
auto-merge was automatically disabled November 29, 2024 00:22

Pull request was closed

@xmfcx
Copy link
Contributor

xmfcx commented Nov 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:bot Bot-related tasks. tag:run-health-check Run health-check tag:sync-files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant