Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snowman use snowflake directly instead of snowball #3403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make snowman use snowflake directly instead of snowball #3403

wants to merge 1 commit into from
+78 −14

Commits on Oct 21, 2024

  1. Make snowman use snowflake directly instead of snowball 

    Snowball was introduced in order to improve the stability of snowflake,
by taking into account the history when returning the preference.

However, if deployed with a configuration where the preference is small enough, and a network partition
causes a 50-50 split of the stake, it can actually backfire, as described in 6e1a905.

Additionally, latest research [1] points out that snowflake suffices for snowman.

This commit removes snowball from snowman and adds a test that simulates a mixed network
which runs snowman with and without snowball, and ensures that a mixed network still converges.

[1] https://arxiv.org/abs/2404.14250

Signed-off-by: Yacov Manevich <[email protected]>
    @yacovm
    yacovm committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    90fd999 View commit details
    Browse the repository at this point in the history