Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub-zero ascii font #3463

Closed
wants to merge 3 commits into from
Closed

sub-zero ascii font #3463

wants to merge 3 commits into from

Conversation

meaghanfitzgerald
Copy link
Contributor

@meaghanfitzgerald meaghanfitzgerald commented Oct 11, 2024

Why this should be merged

Significantly improves UX

How this was tested

https://www.patorjk.com/software/taag/#p=display&f=Sub-Zero&t=Avalanche
./build/avalanchego

Signed-off-by: Meaghan FitzGerald <[email protected]>
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
/ | \ / / __ \| |__/ __ \| | \ \___| Y \ ___/ \>> |
\____|__ /\_/ (____ /____(____ /___| /\___ >___| /\___ > \\
\/ \/ \/ \/ \/ \/ \/`
const Header = `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skier must stay - for significant UX reasons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnlgtm

@StephenButtolph
Copy link
Contributor

Also we should keep the banner <= 80 characters for best terminal UX

Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Meaghan FitzGerald <[email protected]>
Copy link

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants