Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility issue with Magento 2.4.4. which is fixed in Avataxclie… #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeeshan2523806
Copy link

@zeeshan2523806 zeeshan2523806 commented Apr 19, 2022

It seems the root avalara/avatax-magento require fixed and older version of avalara/avataxclient (20.12.1 ) https://github.com/avadev/Avalara-AvaTax-for-Magento2/blob/master/composer.json#L9 which does not seems to be compatible with guzzlehttp/guzzle version 7.x.x as it only require version 6 of that package, but i can see this has been fixed in the latest version of avalara/avataxclient (22.3.0) https://github.com/avadev/AvaTax-REST-V2-PHP-SDK/blob/master/composer.json#L40 but unfortunately we can't install that module as the avalara/avatax-magento only require the version to be fixed at 20.12.1. Please see below screenshot.

image

Solution:
the quick solution is to remove the fix version dependency we have in avalara/avatax-magento for avalara/avataxclient so that it should automatically pull the latest version of it. or we can just change the dependency to be compatible with latest version so that we can install this module with the latest Magento version (2.4.4)

@zeeshan2523806
Copy link
Author

@virtual97 can you please review and merge as its effecting all the merchants who will go through with the latest version of Magento (2.4.4)

@sims-smith-corona
Copy link

atically pull the latest version of it. or we can just change the dependency to be compatible with latest version so that we can install this module with the latest Magento version (2.4.4)

It appears that as of 2.2.10-alpha1, they've updated the version of avalara/avataxclient to "^21.6.0" which in turns is support Guzzle 6 & 7.

@zeeshan2523806
Copy link
Author

@sims-smith-corona cool. any plan on when it would be available as a stable release?

@sims-smith-corona
Copy link

@sims-smith-corona cool. any plan on when it would be available as a stable release?

Unfortunately I have no idea.

There remain additional compatibility issues with Magento 2.4.4 such as the method signature issue discussed at #44 as well as some issues with avalara/avataxclient affecting compatibility with PHP 8.1 (instances where optional function parameters precede required ones which was deprecated in PHP 8.0 and results in blocking errors when trying to run Magento CLI commands.)

@dayoung-adobe
Copy link

Team,

Has there been any indication as to an ETA for the next release of the underlying avataxclient module?

Best,
David

@onebrady
Copy link

onebrady commented May 5, 2022

I am also needing to install Avalara with Magento 2.4.4. I'm getting this issue but I assume it's probably related

Impossible to process constructor argument Parameter #0 [ Zend\Serializer\Adapter\PhpSerialize $phpSerialize ] of ClassyLlama\AvaTax\Framework\Interaction\Rest\Address\Cacheable class

@sajid-snapraise
Copy link

@onebrady having similar issue what was your fix ?

@valenciaisaza
Copy link

valenciaisaza commented Jul 13, 2022

@onebrady I have the same issues in other class

Area configuration aggregation... 5/9 [===============>------------]  55% 2 mins 440.0 MiB
In ClassReader.php line 57:
                                                                                                                                                                                                     
  Impossible to process constructor argument Parameter #3 [ <required> Zend\Serializer\Adapter\PhpSerialize $phpSerialize ] of ClassyLlama\AvaTax\Framework\Interaction\Storage\ResultStorage class  
                                                                                                                                                                                                     

In GetParameterClassTrait.php line 34:
                                                               
  Class "Zend\Serializer\Adapter\PhpSerialize" does not exist  
                                                               

setup:di:compile

I see the use of Zend\Serializer\Adapter\PhpSerialize in 3 Classes in the extension. this need to be changed because Zend was deprecated against Laminas

Alternative Solution
The way I solved this was adding to the composer.json the laminas/serializer package, because it adds too the "laminas/laminas-router" and that package solve the problem, routing the call of Zend\Serializer\Adapter\PhpSerialize to the correct Laminas serializer

Command:
php composer require laminas/laminas-serializer

@sajid-snapraise
Copy link

"avalara/avatax-magento": "^2.2",
This did help me in composer.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants