Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala & libs, fix tests & compilation #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igor-vovk
Copy link

Hi and thank you for your work on this library!

We are trying to use the library as a part of GRPC adoption process, and thus we needed to bring it to the latest versions of everything. This PR is quite heavy on changes, from the major library updates:

  • Added Scala 3.3 compilation target (latest LTS release)
  • Updated cats-effect from v2 to v3.
  • Updated Akka Http
  • protobuf and grpc libraries were updated to their latest versions
  • latest sbt version

Notable changes:

  • Updating cats-effect to v3 required an addition of LiftToFuture class, since there is no way to convert F to Future in latest cats-effect library
  • Updating Akka-Http required a little bit different approach when working with Content-Type headers. Akka's Content-Type class constructor is now package-private. So the header is now defined either as a part of RequestEntity or during the serialization stage.
  • fixed protoc binary download on ARM-architecture (M1 Macs)
  • fixed test flakiness because of use System.nanoTime when creating ReflectionGrpcBridge (non-unique)
  • unapply pattern when defining variables in tests (val Some(...) = ...) was throwing an error and required adding @unchecked, decided to remove it and match against particular wrappers

Further improvements:

  • I want to open a separate PR with migration from Akka to Pekko. This will require changing namespaces. Please tell WDYT about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant