Fix token location computing #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadeasKucera
force-pushed
the
fix_location_computing
branch
from
a6bfe1a
to
bba7301
Compare
metthal
reviewed
Aug 13, 2020
tests/python/test_parser.py
Outdated
| self.assertEqual(string1.token_last.location.end.line, 3) | ||
| self.assertEqual(string1.token_last.location.end.column, 27) | ||
|
|
||
| string2 = rule.strings[1] | ||
| self.assertEqual(string2.identifier, '$2') | ||
| self.assertEqual(string2.location.begin.line, 4) | ||
| self.assertEqual(string2.location.begin.column, 10) | ||
| # self.assertEqual(string2.location.end.line, 4) # FIXME: 4 != 8 | ||
| # self.assertEqual(string2.location.end.column, 40) # FIXME: 2 != 40 | ||
| self.assertEqual(string2.location.end.line, 4) # FIXME: 4 != 8 |
MatejKastak
approved these changes
Aug 14, 2020
| @@ -21,13 +22,19 @@ class Location | |||
| */ | |||
| struct Position { | |||
|
|
|||
| Position() : line(1), column(0) {} | |||
There was a problem hiding this comment.
I think it would be beneficial to add comment about how we count lines and columns.
- lines from 1
- columns from 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the location of tokens of strings.