Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PinPayments] purchase and refund function with test cases #146

Open
wants to merge 28 commits into
base: pinpay
Choose a base branch
from

Conversation

ravirocx
Copy link

@ravirocx ravirocx commented Mar 31, 2018

PinPayments

purchase/3

  • Implemented two purchase function:
  1. With card params
  2. With card Token

refund/2

  • Implemented refund function

Docs

  • Added docs for purchase/3.
  • Added docs for refund/3

Tests

  • Added integration tests for purchase/3, using ExVCR.
  • Added integration tests for refund/2, using ExVCR.

function store/2 is also added, as the purchase was dependent on store

@ravirocx ravirocx changed the title [PinPayments] purchase\3 function with test cases [PinPayments] purchase function with test cases Mar 31, 2018
@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #146 into pinpay will increase coverage by 6.11%.
The diff coverage is 80.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           pinpay     #146      +/-   ##
==========================================
+ Coverage   60.04%   66.15%   +6.11%     
==========================================
  Files          15       15              
  Lines         498      520      +22     
==========================================
+ Hits          299      344      +45     
+ Misses        199      176      -23
Impacted Files Coverage Δ
lib/gringotts/gateways/pin_payments.ex 80.43% <80.43%> (+80.43%) ⬆️
lib/gringotts/gateways/global_collect.ex 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f0aca...0d09a81. Read the comment docs.

@ravirocx ravirocx changed the title [PinPayments] purchase function with test cases [PinPayments] purchase and refund function with test cases May 1, 2018
@ravirocx ravirocx self-assigned this May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants