Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appstore): change the response of api server from interface to specific response #304

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

richzw
Copy link
Collaborator

@richzw richzw commented Nov 15, 2024

Per the discussion #301, changing the response from an interface to a specific response could be more convenient for users.

I'd like to welcome further discussion. 😃

Copy link
Member

@takecy takecy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply and discussion.
I thought about responding to generics, but I thought it would be problematic to respond only to this interface.

I think this PR response is fine 👍

@takecy takecy merged commit 195f7cf into awa:master Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants