Skip to content

Commit

Permalink
Raise PHP to 7.1, fix #60
Browse files Browse the repository at this point in the history
  • Loading branch information
kagg-design authored Dec 16, 2024
1 parent 9335fe6 commit ae6f849
Show file tree
Hide file tree
Showing 6 changed files with 141 additions and 99 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Changelog
All notable changes to this project will be documented in this file and formatted via [this recommendation](https://keepachangelog.com/).

## [1.3.0] - 2024-12-16
### Changed
- The minimum supported PHP version is now 7.1.

### Fixed
- Return tag hook sniff did not work.

## [1.2.3] - 2024-08-29
- Rule "WordPressVIPMinimum.Performance.WPQueryParams" is added as required by Plugin Check Plugin.
- Rule "WordPress.DB.DirectDatabaseQuery.DirectQuery" is not suppressed anymore as required by the Plugin Check Plugin.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @since 1.0.0
*/
class ReturnTagHooks extends BaseSniff implements Sniff {
class ReturnTagHooksSniff extends BaseSniff implements Sniff {

use CommentTag;

Expand Down
4 changes: 2 additions & 2 deletions WPForms/Tests/Tests/Comments/ReturnTagHooksTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace WPForms\Tests\Comments;

use WPForms\Tests\TestCase;
use WPForms\Sniffs\Comments\ReturnTagHooks;
use WPForms\Sniffs\Comments\ReturnTagHooksSniff;

/**
* Class ReturnTagHooksTest.
Expand All @@ -19,7 +19,7 @@ class ReturnTagHooksTest extends TestCase {
*/
public function testProcess() {

$phpcsFile = $this->process( new ReturnTagHooks() );
$phpcsFile = $this->process( new ReturnTagHooksSniff() );

$this->fileHasErrors( $phpcsFile, 'UnnecessaryReturnTag', [ 80 ] );
$this->fileHasErrors( $phpcsFile, 'AddReturnTag', [ 106 ] );
Expand Down
2 changes: 1 addition & 1 deletion WPForms/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<arg name="parallel" value="12"/>
<arg name="extensions" value="php"/>

<config name="testVersion" value="7.0-"/>
<config name="testVersion" value="7.1-"/>

<!-- Rules: Check PHP version compatibility. -->
<rule ref="PHPCompatibility">
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"require": {
"automattic/vipwpcs": "^3.0.1",
"phpcompatibility/php-compatibility": "^9.3.5",
"squizlabs/php_codesniffer": "^3.10.2",
"squizlabs/php_codesniffer": "^3.11.2",
"wp-coding-standards/wpcs": "^3.1.0"
},
"require-dev": {
Expand Down
Loading

0 comments on commit ae6f849

Please sign in to comment.