Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added static context to clear the .amplify/generated/env Directory before synthesis #2054

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

vigy02
Copy link
Contributor

@vigy02 vigy02 commented Sep 25, 2024

Follow up PR: #2044

Using this PR to run the e2e test

Problem

The .amplify/generated/env/ directory is not cleared before deployments, causing outdated/renamed environment files to remain. This can lead to confusion and potential errors when the function's handler code does not match the current environment settings.

@vigy02 vigy02 added the run-e2e Label that will include e2e tests in PR checks workflow label Sep 25, 2024
@vigy02 vigy02 requested a review from a team as a code owner September 25, 2024 18:59
Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: a6fcbcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend-function Patch
@aws-amplify/backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@awsluja awsluja closed this Sep 25, 2024
@awsluja awsluja reopened this Sep 25, 2024
Copy link
Contributor

@awsluja awsluja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a small nit regarding test naming

awsluja
awsluja previously approved these changes Oct 9, 2024
sobolk
sobolk previously approved these changes Oct 9, 2024
@vigy02 vigy02 removed the run-e2e Label that will include e2e tests in PR checks workflow label Oct 9, 2024
@vigy02 vigy02 dismissed stale reviews from sobolk and awsluja via 2b312c4 October 10, 2024 23:52
@awsluja awsluja added the run-e2e Label that will include e2e tests in PR checks workflow label Oct 14, 2024
@awsluja awsluja closed this Oct 14, 2024
@awsluja awsluja reopened this Oct 14, 2024
awsluja
awsluja previously approved these changes Oct 14, 2024
sobolk
sobolk previously approved these changes Nov 6, 2024
@vigy02 vigy02 dismissed stale reviews from sobolk and awsluja via a6fcbcf November 6, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants