Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip network monitoring for watchOS #3272

Closed
wants to merge 5 commits into from
Closed

fix: skip network monitoring for watchOS #3272

wants to merge 5 commits into from

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Oct 4, 2023

Issue #

#3220

Description

Uses the changes from aws-amplify/aws-appsync-realtime-client-ios#139. See this for more details.

Testing

We need to run this app on a physical device to fully verify that the issue is fixed. However, running on a simulator, we can check that there are no logs around network monitoring.

The logs around networking monitoring looks like this:

[RealtimeConnectionProvider] Status: inProgress. Connectivity status: unsatisfied

Running the app on a simulator and then calling DataStore.start() shows that there are no "Connectivity" related logs

https://github.com/lawmicha/watchOSTestApp/blob/main/logs/start.logs

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant