Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry create/update on workgroup conflict exception #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mashuaihh
Copy link
Contributor

In eu-north-1 region, some wf steps take longer to finish, and contract test would fail because of ConflictException("There is an operation running on the workgroup") and contract test will fail.

This commit handles the exception by matching the exception message and retry on the exception, giving the wf more time to finish.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

In eu-north-1 region, some wf steps take longer to finish, and contract
test would fail because of ConflictException("There is an operation
running on the workgroup") and contract test will fail.

This commit handles the exception by matching the exception message and
retry on the exception, giving the wf more time to finish.
awsResponse = proxyClient.injectCredentialsAndInvokeV2(awsRequest, proxyClient.client()::getWorkgroup);
awsResponse = proxyClient.injectCredentialsAndInvokeV2(awsRequest, proxyClient.client()::getWorkgroup);

logger.log(String.format("%s has yo successfully been read.", ResourceModel.TYPE_NAME));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let me revise that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants