Make all plugin and dependencies managed in the parent pom.xml #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a well known Maven technique to simplify managing versions in a package with submodules. Most of the plugins and dependencies are placed in the top level pom.xml and versions can be managed either with dependencyManagement or properties where needed. The RPDK plugin needs to be executed in the context of the module it is working for so we could not consolidate that too at the top pom.xml.
Alex-Vol-Amz
force-pushed
the
make-better-maven-build
branch
from
1d8d54d
to
988f551
Compare
vicwuqinyi
approved these changes
Jul 1, 2024
aws-sde
approved these changes
Jul 8, 2024
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <cfn.generate.args/> | ||
| <!-- Keep all module versions here --> |
There was a problem hiding this comment.
Nice! This is more readable and easier to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a well known Maven technique to simplify managing versions in a package with submodules. Most of the plugins and dependencies are placed in the top level pom.xml and versions can be managed either with dependencyManagement or properties where needed.
The RPDK plugin needs to be executed in the context of the module it is working for so we could not consolidate that too at the top pom.xml.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.