feat: add optional parameter for function name #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayrane
reviewed
Feb 29, 2024
| @@ -123,12 +123,50 @@ The Lambda version of the tool is a lightweight wrapper around the core [cfn-gua | |||
|
|
|||
| ### Building and deploying | |||
|
|
|||
| #### Guided | |||
|
|
|||
| 1. Make sure docker is running | |||
| 2. Navigate to `guard-lambda` directory and run `sam build --use-container` to build the code for the Lambda function | |||
| 3. Run `sam deploy --guided` and complete the interactive workflow. This workflow will create a CloudFormation changeset and deploy it | |||
| 4. Once it succeeds, the name of the function will be shown in the `CloudFormationGuardLambdaFunctionName` output | |||
There was a problem hiding this comment.
If we are asking user to pass a parameter for name this line will change, correct?
There was a problem hiding this comment.
If a samconfig.toml is not being used, you are correct. sam deploy will need this added. I will update the PR.
There was a problem hiding this comment.
I misunderstood - no, I don't think this will need to change. The output does not change by having a stack parameter. Also, if following the guided approach, it should be managed through the interactive process. The parameter is not required, so already existing consumers will not need to add it.
|
Hi @jkruse14 I was wondering if you are able to look at the comments @akshayrane has left when you have a moment. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Adds an optional parameter to the CloudFormation stack to be able to specify a
FunctionNamewhen installing with the SAM CLI. The README is updated with CI/CD (non-guided) instructions including how to specify theparameter-overridefor theFunctionNameBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license