-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CloudFront Functions example #22
Conversation
cdk/typescript/cloudfront-functions/lib/demo-cloudfront-functions-stack.ts
Outdated
Show resolved
Hide resolved
cdk/typescript/cloudfront-functions/lib/demo-cloudfront-functions-stack.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?
It was just because the WDYT of merging both examples, applying the comments above, and changing the name to just |
If the differences are not too significant I'm ok with that. We could also merge with the |
After evaluating the three different examples regarding CloudFront, I merged both that are focused on deploying CloudFront Functions as
What do you think @ericzbeard ? |
Issue: #12
Description of changes:
Added CloudFront Functions example with both request and response functions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.