Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CloudFront Functions example #22

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

paulosergio-jnr
Copy link
Contributor

Issue: #12

Description of changes:
Added CloudFront Functions example with both request and response functions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

@paulosergio-jnr
Copy link
Contributor Author

paulosergio-jnr commented Jun 3, 2024

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

It was just because the -headers suffix in the directory's name seemed to be something very specific.

WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions?

@ericzbeard
Copy link
Contributor

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

It was just because the -headers suffix in the directory's name seemed to be something very specific.

WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions?

If the differences are not too significant I'm ok with that. We could also merge with the cloudfront app and just have one

@paulosergio-jnr
Copy link
Contributor Author

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

It was just because the -headers suffix in the directory's name seemed to be something very specific.
WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions?

If the differences are not too significant I'm ok with that. We could also merge with the cloudfront app and just have one

After evaluating the three different examples regarding CloudFront, I merged both that are focused on deploying CloudFront Functions as cloudfront-functions and let the cloudfront as is given these points:

  • cloudfront example deploys the cloudfront distribution in a simpler way compared to the other two.
  • cloudfront example has a considerable more complex comment to create the cloudfront distribution.
  • cloudfront example is using pre-created resources, as the other two examples are creating the whole environment from scratch.

What do you think @ericzbeard ?

@ericzbeard ericzbeard merged commit 2e8e794 into aws-cloudformation:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants