Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the self reference and sed to work #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed the self reference and sed to work #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97ab9a9
removed self reference in nodejs vn
Feb 22, 2023
713da00
to make the sed work
Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cdk/cdk/nodejsservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
compatibility=aws_ecs.Compatibility.EC2_AND_FARGATE,
cpu='256',
memory_mib='512',
# appmesh-proxy-uncomment
#appmesh-proxy-uncomment
# proxy_configuration=aws_ecs.AppMeshProxyConfiguration(
# container_name="envoy", # App Mesh side card name that will proxy the requests
# properties=aws_ecs.AppMeshProxyConfigurationProps(
Expand All @@ -41,7 +41,7 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
# ignored_uid=1337 # side card default config
# )
# )
# appmesh-proxy-uncomment
#appmesh-proxy-uncomment
)

log_group = aws_logs.LogGroup(
Expand Down Expand Up @@ -235,7 +235,7 @@ def appmesh(self):
# Adding mesh virtual service
self.mesh_nodejs_vs = aws_appmesh.VirtualService(self, "mesh-nodejs-vs",
virtual_service_provider=aws_appmesh.VirtualServiceProvider.virtual_node(
self.mesh_nodejs_vn),
mesh_nodejs_vn),
virtual_service_name="{}.{}".format(
self.fargate_service.cloud_map_service.service_name, self.fargate_service.cloud_map_service.namespace.namespace_name)
)
Expand Down