Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gabeaws/jenkins/complete example #240

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

gabebatista
Copy link
Contributor

Issue number: 176

Summary

Adds simple, but complete, example of deploying Jenkins on its own.

Changes

Adds simple, but complete, example of deploying Jenkins on its own.
Fixes Jenkins Route53 record name to properly align with certificate

User experience

Users now have a simple example demonstrating how to deploy Jenkins on its own

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change? No

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@gabebatista gabebatista added the modules Updates to project modules label Sep 4, 2024
@gabebatista gabebatista self-assigned this Sep 4, 2024
@gabebatista gabebatista requested a review from a team as a code owner September 4, 2024 21:12
@gabebatista gabebatista requested a review from squidbot September 4, 2024 21:12
modules/jenkins/examples/complete/vpc.tf Fixed Show resolved Hide resolved
modules/jenkins/examples/complete/vpc.tf Dismissed Show resolved Hide resolved
@henrykie henrykie force-pushed the gabeaws/jenkins/complete-example branch from 7e034a9 to 7de6d96 Compare September 6, 2024 16:43
Copy link
Contributor

@henrykie henrykie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments to resolve, but overall it looks good.

Make these changes, and then commit these updates with the following message:

feat(jenkins example): Adding simple example deployment of Jenkins for automated testing

modules/jenkins/examples/complete/dns.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/dns.tf Show resolved Hide resolved
modules/jenkins/examples/complete/dns.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/local.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/local.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/vpc.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/vpc.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/vpc.tf Dismissed Show resolved Hide resolved
modules/jenkins/examples/complete/vpc.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/vpc.tf Outdated Show resolved Hide resolved
@gabebatista gabebatista force-pushed the gabeaws/jenkins/complete-example branch from 7de6d96 to a9fae08 Compare September 12, 2024 20:54
modules/jenkins/examples/complete/vpc.tf Dismissed Show dismissed Hide dismissed
henrykie
henrykie previously approved these changes Sep 12, 2024
modules/jenkins/examples/complete/versions.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/variables.tf Outdated Show resolved Hide resolved
modules/jenkins/examples/complete/variables.tf Outdated Show resolved Hide resolved
jorisdon
jorisdon previously approved these changes Sep 13, 2024
@gabebatista gabebatista force-pushed the gabeaws/jenkins/complete-example branch from c06f047 to 267c9b8 Compare September 13, 2024 14:19
@henrykie henrykie merged commit 59f3aee into main Sep 24, 2024
7 checks passed
kylesomers pushed a commit that referenced this pull request Sep 27, 2024
@henrykie henrykie deleted the gabeaws/jenkins/complete-example branch September 29, 2024 05:05
@henrykie henrykie restored the gabeaws/jenkins/complete-example branch September 29, 2024 05:05
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Updates to project modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants