-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gabeaws/jenkins/complete example #240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrykie
force-pushed
the
gabeaws/jenkins/complete-example
branch
from
September 6, 2024 16:43
7e034a9
to
7de6d96
Compare
henrykie
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments to resolve, but overall it looks good.
Make these changes, and then commit these updates with the following message:
feat(jenkins example): Adding simple example deployment of Jenkins for automated testing
gabebatista
force-pushed
the
gabeaws/jenkins/complete-example
branch
from
September 12, 2024 20:54
7de6d96
to
a9fae08
Compare
henrykie
previously approved these changes
Sep 12, 2024
jorisdon
requested changes
Sep 13, 2024
jorisdon
previously approved these changes
Sep 13, 2024
gabebatista
force-pushed
the
gabeaws/jenkins/complete-example
branch
from
September 13, 2024 14:19
c06f047
to
267c9b8
Compare
…r automated testing
… 'fully_qualified_domain_name' variable and sets 'jenkins_agent_secret_arns' default to '[]'
henrykie
force-pushed
the
gabeaws/jenkins/complete-example
branch
from
September 24, 2024 17:22
492426c
to
8e305b6
Compare
henrykie
approved these changes
Sep 24, 2024
kylesomers
pushed a commit
that referenced
this pull request
Sep 27, 2024
jcwolfaws
pushed a commit
to jcwolfaws/cloud-game-development-toolkit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: 176
Summary
Adds simple, but complete, example of deploying Jenkins on its own.
Changes
Adds simple, but complete, example of deploying Jenkins on its own.
Fixes Jenkins Route53 record name to properly align with certificate
User experience
Users now have a simple example demonstrating how to deploy Jenkins on its own
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.