Set ASP.NET Core runtime environment #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrykie
approved these changes
Sep 12, 2024
| @@ -21,8 +21,8 @@ variable "project_prefix" { | |||
|
|
|||
| variable "environment" { | |||
| type = string | |||
| description = "The current environment (e.g. dev, prod, etc.)" | |||
| default = "dev" | |||
| description = "The current environment (e.g. Development, Staging, Production, etc.). This will tag ressources and set ASPNETCORE_ENVIRONMENT variable." | |||
There was a problem hiding this comment.
nit. can fix in my next PR.
henrykie
pushed a commit
that referenced
this pull request
Sep 17, 2024
henrykie
pushed a commit
that referenced
this pull request
Sep 17, 2024
henrykie
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Use the environment variable to set the ASP.NET Core runtime environment for horde server.
User experience
Admin can now see that horde server is running in the desired runtime environment when looking at the container logs.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.