-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for CASE_SENSITIVE setting #313
Conversation
This is my first pass @henrykie which works, but I'm sure you will want to make the wording better :) |
@GrzesiekO take a look... |
@keith-miller this looks great to me. If it works for you then I'll let @GrzesiekO review - he may want to use this approach for now. We've been going back and forth on replacing this bash script entirely eventually, and as new requests for modifications come in we're leaning more and more that way. We still need to set unicode mode. My understanding is you can do that against the server once it is already booted? We will still want to consider doing it by default. |
@henrykie that's correct. We were able to enable unicode support after the fact and are unblocked using this code. |
Seen the changes need to test it but seems like a quick fix following current pattern. Thank you @keith-miller! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes with current convention. Adds case sensitivity option for p4d.
Approving.
Co-authored-by: Kyle Somers <[email protected]>
Co-authored-by: Kyle Somers <[email protected]>
resolves #302
Issue number:
Summary
Changes
Added support for CASE_SENSITIVE setting
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.