Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CASE_SENSITIVE setting #313

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

keith-miller
Copy link
Contributor

resolves #302

Issue number:

Summary

Changes

Added support for CASE_SENSITIVE setting

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • [ X] I have performed a self-review of this change
  • [ X] Changes have been tested
  • Changes are documented
Is this a breaking change?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@keith-miller keith-miller requested a review from a team as a code owner September 25, 2024 20:08
@keith-miller
Copy link
Contributor Author

This is my first pass @henrykie which works, but I'm sure you will want to make the wording better :)

@henrykie
Copy link
Contributor

@GrzesiekO take a look...

@henrykie
Copy link
Contributor

@keith-miller this looks great to me. If it works for you then I'll let @GrzesiekO review - he may want to use this approach for now. We've been going back and forth on replacing this bash script entirely eventually, and as new requests for modifications come in we're leaning more and more that way.

We still need to set unicode mode. My understanding is you can do that against the server once it is already booted? We will still want to consider doing it by default.

@keith-miller
Copy link
Contributor Author

@henrykie that's correct. We were able to enable unicode support after the fact and are unblocked using this code.

@jorisdon jorisdon requested a review from GrzesiekO September 26, 2024 08:19
@GrzesiekO GrzesiekO self-assigned this Sep 26, 2024
@GrzesiekO
Copy link
Contributor

Seen the changes need to test it but seems like a quick fix following current pattern. Thank you @keith-miller!

Copy link
Contributor

@GrzesiekO GrzesiekO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes with current convention. Adds case sensitivity option for p4d.
Approving.

@henrykie henrykie merged commit 848f061 into aws-games:main Sep 26, 2024
7 checks passed
kylesomers added a commit that referenced this pull request Sep 27, 2024
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Ability to set case sensitivity in Helix Core
4 participants