-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jenkins): Adds GHA deployment workflow #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabebatista
had a problem deploying
to
${ GITHUB_ENVIRONMENT }
September 30, 2024 15:24 — with
GitHub Actions
Failure
gabebatista
had a problem deploying
to
$GITHUB_ENVIRONMENT
September 30, 2024 19:04 — with
GitHub Actions
Failure
gabebatista
had a problem deploying
to
aws-ci
September 30, 2024 19:11 — with
GitHub Actions
Failure
gabebatista
had a problem deploying
to
aws-ci
September 30, 2024 19:19 — with
GitHub Actions
Failure
gabebatista
had a problem deploying
to
aws-ci
September 30, 2024 19:28 — with
GitHub Actions
Failure
jorisdon
previously approved these changes
Oct 2, 2024
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 4, 2024 14:52
59b596d
to
084b5b6
Compare
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 4, 2024 15:11
084b5b6
to
b93701b
Compare
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 18, 2024 14:55
b93701b
to
7b18e38
Compare
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 18, 2024 18:12
7b18e38
to
208ca4b
Compare
gabebatista
changed the title
Gabeaws/jenkins/gha deployment workflow
feat(jenkins): Adds deployment workflow
Oct 18, 2024
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 18, 2024 18:43
208ca4b
to
b6673e1
Compare
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 18, 2024 18:59
b6673e1
to
389345b
Compare
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 18, 2024 19:03
389345b
to
11129b8
Compare
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 18, 2024 19:55
11129b8
to
96fe0cc
Compare
Terraform Plan 📖
|
gabebatista
changed the title
feat(jenkins): Adds deployment workflow
feat(jenkins): Adds GHA deployment workflow
Oct 21, 2024
gabebatista
requested review from
jorisdon,
kylesomers and
henrykie
and removed request for
novekm
October 21, 2024 14:02
jorisdon
approved these changes
Oct 21, 2024
…o allow automated deployment and destruction of module
gabebatista
force-pushed
the
gabeaws/jenkins/gha-deployment-workflow
branch
from
October 22, 2024 13:59
96fe0cc
to
4328d99
Compare
novekm
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
Adds a Github Actions workflow to plan, deploy and destroy the jenkins complete example template. This workflow triggers on any changes to
modules/jenkins/*
. Some best practice features have been disabled as they cause the automated destruction of the solution to fail.Changes
modules/jenkins/*
terraform plan
and posts the output as a comment in the triggering PRcloud-game-development+ci
AWS accountcloud-game-development+ci
AWS accountmodules/jenkins/examples/complete
template to allow for automated destruction of solution:terraform destroy
cannot delete s3 buckets that are not empty)terraform destroy
cannot delete the ALB if deletion protection is enabled)User experience
These changes will allow the repository maintainers to more easily test changes made to the Jenkins module. Deployment and Destruction of environments are done based on manual approval steps, so use of this workflow is optional.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.