initial commit of unreal cloud ddc module and sample #341

danielw-aws · 2024-10-03T16:35:51Z

Issue number:

Summary

Added single region example and Unreal Cloud DDC modules to CGD

Changes

Added files to instantiate and deploy Unreal Cloud DDC

User experience

Nothing has changed except adding two modules for unreal cloud DDC

Checklist

If your change doesn't seem to apply, please leave them unchecked.

I have performed a self-review of this change
Changes have been tested
Changes are documented

Is this a breaking change? No

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

github-advanced-security

Checkov found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

modules/unreal/unreal-cloud-ddc-infra/main.tf

modules/unreal/unreal-cloud-ddc-intra-cluster/main.tf

samples/unreal-cloud-ddc-single-region/vpc/main.tf

henrykie

Lets grab some time and you can explain a lot of the little nit-picky things. Generally looks really good!

samples/unreal-cloud-ddc-single-region/vpc/main.tf

samples/unreal-cloud-ddc-single-region/vpc/versions.tf

samples/unreal-cloud-ddc-single-region/variables.tf

modules/unreal/unreal-cloud-ddc-intra-cluster/main.tf

modules/unreal/unreal-cloud-ddc-intra-cluster/outputs.tf

henrykie · 2024-10-03T19:44:14Z

modules/unreal/unreal-cloud-ddc-intra-cluster/variables.tf

+variable "oidc_provider_arn" {
+  type        = string
+  description = "ARN of the OIDC Provider from EKS Cluster"
+}


from or for EKS cluster?

henrykie · 2024-10-03T19:44:32Z

modules/unreal/unreal-cloud-ddc-intra-cluster/variables.tf

+variable "external_secrets_secret_manager_arn_list" {
+  type        = list(string)
+  description = "List of ARNS for Secret Manager Secrets to use in Unreal Cloud DDC"
+  default     = []
+}


What are these for? How do they get used?

henrykie · 2024-10-03T19:46:42Z

Your most recent merge commit should be removed. Rebase main onto this feature branch instead. Also, signing is missing on the first commit.

jorisdon · 2024-10-04T12:26:20Z

modules/unreal/unreal-cloud-ddc-infra/main.tf

+  #checkov:skip=CKV2_AWS_38:Ensure Domain Name System Security Extensions (DNSSEC) signing is enabled for Amazon Route 53 public hosted zones
+  #checkov:skip=CKV2_AWS_39:Ensure Domain Name System (DNS) query logging is enabled for Amazon Route 53 hosted zones


The comment should explain why a checkov check is skipped, not what is skipped.

jorisdon · 2024-10-04T12:59:23Z

modules/unreal/unreal-cloud-ddc-infra/main.tf

+  vpc_id      = var.vpc_id
+
+  tags = {
+    Name = "unreal-cloud-ddc-system-sg"


Parameterizing this name (like we do in

cloud-game-development-toolkit/modules/jenkins/asg.tf

Line 48 in 541b6a7

value = "${local.name_prefix}-${each.key}-build-farm"

) would be useful.

The same applies in other locations in this file; allowing a prefix allows deploying multiple DDCs in an account in a way which makes them easily distinguishable.

jorisdon · 2024-10-04T13:30:03Z

samples/unreal-cloud-ddc-single-region/main.tf

+  s3_bucket_id = module.unreal_cloud_ddc_infra.s3_bucket_id
+
+  unreal_cloud_ddc_helm_values = [
+    templatefile("./assets/unreal_cloud_ddc_region_values.yaml", {


this template file is missing; is it generated or do we expect users to provide it themselves?

jorisdon · 2024-10-04T13:30:35Z

samples/unreal-cloud-ddc-single-region/main.tf

+      region      = data.aws_region.current.name
+      bucket_name = module.unreal_cloud_ddc_infra.s3_bucket_id
+    }),
+    templatefile("./assets/unreal_cloud_ddc_base.yaml", {


this template file is missing; is it generated or do we expect users to provide it themselves?

It still sits in modules/unreal/samples/unreal-cloud-ddc-single-region/assets instead of the root assets directory. I presume we still think it should migrate higher up?

gabebatista

I think Henry hit most of the important points. Added some comments for minor things.

gabebatista · 2024-10-04T19:38:05Z

modules/unreal/unreal-cloud-ddc-infra/main.tf

+  scylla_user_data = jsonencode(
+    { "scylla_yaml" : {
+      "cluster_name" : local.scylla_variables.scylla-cluster-name,
+      "seed_provider" : [
+        { "class_name" : "org.apache.cassandra.locator.SimpleSeedProvider",
+          "parameters" : [
+            { "seeds" : "test-ip" }
+          ]
+        }
+      ]
+      },
+  "start_scylla_on_first_boot" : true })
+  nvme-pre-bootstrap-userdata = <<EOF
+MIME-Version: 1.0
+Content-Type: multipart/mixed; boundary="//"
+
+--//
+Content-Type: text/x-shellscript; charset="us-ascii"
+
+#!/bin/bash
+sudo mkfs.ext4 -E nodiscard /dev/nvme1n1
+sudo mkdir /data
+sudo mount /dev/nvme1n1 /data
+--//--\
+EOF


gabebatista · 2024-10-04T19:41:35Z

modules/unreal/unreal-cloud-ddc-infra/main.tf

+  description       = "Self SG Egress"
+}
+
+# ################################################################################


What are these commented SGs? Should they be removed if not in use?

modules/unreal/unreal-cloud-ddc-infra/main.tf

gabebatista · 2024-10-04T20:01:54Z

modules/unreal/unreal-cloud-ddc-infra/variables.tf

+  type        = list(string)
+  default     = []
+  description = "Private subnets you want scylla and the worker nodes to be installed into."
+}


Always describe exactly what you expected to be passed for a variable. For example, Subnets have a subnet ID and a ARN, so it can be confusing for new users to know which to use.

kylesomers

Already some great feedback from others in here. For me, biggest question is EKS versioning and how we want to handle this. What prevents you from using latest EKS version (1.31 I believe)? I'd like to see a runbook of steps for testing the module for EKS version compatibility before we release this. If game devs will take a dependency on this module then we don't want our trailing EKS versioning to be a reason they cannot update their clusters to latest version or need to incur additional cost for EKS extended support for older version.

…ov comments

modules/unreal/unreal-cloud-ddc-infra/s3.tf

+resource "aws_s3_bucket" "unreal_ddc_s3_bucket" {
+  #checkov:skip=CKV_AWS_21:Ensure all data stored in the S3 bucket have versioning enabled
+  #checkov:skip=CKV2_AWS_61:Ensure that an S3 bucket has a lifecycle configuration
+  #checkov:skip=CKV2_AWS_62:This bucket doesnt have any triggers needed as its only an object store
+  #checkov:skip=CKV_AWS_144:This bucket hosts ephemeral recreatable assets
+  bucket_prefix = "${var.name}-s3-bucket"
+  force_destroy = true
+}


modules/unreal/unreal-cloud-ddc-infra/s3.tf

+resource "aws_s3_bucket" "unreal_ddc_s3_bucket" {
+  #checkov:skip=CKV_AWS_21:Ensure all data stored in the S3 bucket have versioning enabled
+  #checkov:skip=CKV2_AWS_61:Ensure that an S3 bucket has a lifecycle configuration
+  #checkov:skip=CKV2_AWS_62:This bucket doesnt have any triggers needed as its only an object store
+  #checkov:skip=CKV_AWS_144:This bucket hosts ephemeral recreatable assets
+  bucket_prefix = "${var.name}-s3-bucket"
+  force_destroy = true
+}


modules/unreal/unreal-cloud-ddc-infra/s3.tf

+resource "aws_s3_bucket" "unreal_ddc_s3_bucket" {
+  #checkov:skip=CKV_AWS_21:Ensure all data stored in the S3 bucket have versioning enabled
+  #checkov:skip=CKV2_AWS_61:Ensure that an S3 bucket has a lifecycle configuration
+  #checkov:skip=CKV2_AWS_62:This bucket doesnt have any triggers needed as its only an object store
+  #checkov:skip=CKV_AWS_144:This bucket hosts ephemeral recreatable assets
+  bucket_prefix = "${var.name}-s3-bucket"
+  force_destroy = true
+}


modules/unreal/unreal-cloud-ddc-infra/s3.tf

+resource "aws_s3_bucket" "unreal_ddc_s3_bucket" {
+  #checkov:skip=CKV_AWS_21:Ensure all data stored in the S3 bucket have versioning enabled
+  #checkov:skip=CKV2_AWS_61:Ensure that an S3 bucket has a lifecycle configuration
+  #checkov:skip=CKV2_AWS_62:This bucket doesnt have any triggers needed as its only an object store
+  #checkov:skip=CKV_AWS_144:This bucket hosts ephemeral recreatable assets
+  bucket_prefix = "${var.name}-s3-bucket"
+  force_destroy = true
+}


…arsing issue on sample

henrykie · 2024-11-07T01:13:58Z

@danielw-aws you need to address the existing requested changes (close out conversations) and re-request reviews for this. We're still failing checkov as well :)

henrykie · 2024-11-13T15:25:52Z

@danielw-aws any updates here that you want me to review?

…les.

danielw-aws · 2024-11-26T22:28:09Z

modules/unreal/unreal-cloud-ddc-infra/eks.tf

+resource "aws_eks_cluster" "unreal_cloud_ddc_eks_cluster" {
+  #checkov:skip=CKV_AWS_39:Ensure Amazon EKS public endpoint disabled
+  #checkov:skip=CKV_AWS_58:Ensure EKS Cluster has Secrets Encryption Enabled
+  #checkov:skip=CKV_AWS_339:Ensure EKS clusters run on a supported Kubernetes version
+  #checkov:skip=CKV_AWS_38:IP restriction set in module variables
+  name                      = var.name
+  role_arn                  = aws_iam_role.eks_cluster_role.arn
+  version                   = var.kubernetes_version
+  enabled_cluster_log_types = ["api", "audit", "authenticator", "controllerManager", "scheduler"]
+
+
+
+  access_config {
+    authentication_mode                         = "API_AND_CONFIG_MAP"
+    bootstrap_cluster_creator_admin_permissions = true
+  }
+
+  vpc_config {
+    subnet_ids              = var.private_subnets
+    endpoint_private_access = true
+    endpoint_public_access  = true
+    public_access_cidrs     = var.eks_cluster_access_cidr
+    security_group_ids = [
+      aws_security_group.system_security_group.id,
+      aws_security_group.worker_security_group.id,
+      aws_security_group.nvme_security_group.id
+    ]
+  }
+}


As long as the access is restricted by SG and defaulted to empty access we can suppress this.

modules/unreal/unreal-cloud-ddc-infra/eks.tf

danielw-aws · 2024-11-26T22:28:47Z

modules/unreal/unreal-cloud-ddc-infra/eks.tf

+resource "aws_cloudwatch_log_group" "unreal_cluster_cloudwatch" {
+  #checkov:skip=CKV_AWS_158:Ensure that CloudWatch Log Group is encrypted by KMS
+  name_prefix       = "/aws/eks/${var.name}/cluster"
+  retention_in_days = 365
+
+}


modules/unreal/unreal-cloud-ddc-infra/s3.tf

modules/unreal/unreal-cloud-ddc-intra-cluster/helm.tf

+module "eks_blueprints_all_other_addons" {
+  #checkov:skip=CKV_TF_1:Ensure Terraform module sources use a commit hash
+  #checkov:skip=CKV_AWS_109:Ensure IAM policies does not allow permissions management / resource exposure without constraints
+  #checkov:skip=CKV_AWS_111:Ensure IAM policies does not allow write access without constraints
+  #checkov:skip=CKV_AWS_356:Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions
+  source = "git::https://github.com/aws-ia/terraform-aws-eks-blueprints-addons.git?ref=a9963f4a0e168f73adb033be594ac35868696a91"
+
+  eks_addons = {
+    coredns = {
+      most_recent = true
+    }
+    kube-proxy = {
+      most_recent = true
+    }
+    vpc-cni = {
+      most_recent = true
+    }
+    aws-ebs-csi-driver = {
+      most_recent              = true
+      service_account_role_arn = module.ebs_csi_irsa_role.iam_role_arn
+    }
+  }
+
+
+  cluster_name      = data.aws_eks_cluster.unreal_cloud_ddc_cluster.name
+  cluster_endpoint  = data.aws_eks_cluster.unreal_cloud_ddc_cluster.endpoint
+  cluster_version   = data.aws_eks_cluster.unreal_cloud_ddc_cluster.version
+  oidc_provider_arn = data.aws_iam_openid_connect_provider.oidc_provider.arn
+
+  enable_aws_load_balancer_controller = true
+  enable_aws_cloudwatch_metrics       = true
+
+  tags = {
+    Environment = var.cluster_name
+  }
+}


henrykie

More updates to address - include comments ASAP, and we can divy up what needs to be fixed. I'll hop on this as well.

modules/unreal/unreal-cloud-ddc-infra/eks.tf

henrykie · 2024-11-25T22:55:15Z

modules/unreal/unreal-cloud-ddc-infra/eks.tf

+  name                      = var.name
+  role_arn                  = aws_iam_role.eks_cluster_role.arn
+  version                   = var.kubernetes_version
+  enabled_cluster_log_types = ["api", "audit", "authenticator", "controllerManager", "scheduler"]


parameterize?

modules/unreal/unreal-cloud-ddc-infra/eks.tf

henrykie · 2024-11-25T22:57:25Z

modules/unreal/unreal-cloud-ddc-infra/eks.tf

+  version         = aws_eks_cluster.unreal_cloud_ddc_eks_cluster.version
+  release_version = nonsensitive(data.aws_ssm_parameter.eks_ami_latest_release.value)
+  node_role_arn   = aws_iam_role.worker_node_group_role.arn
+  subnet_ids      = var.private_subnets


Should the solution be subnet type "agnostic"? Meaning these don't HAVE to be private, you just recommend it when deploying the module?

sure ill parameterize this

modules/unreal/unreal-cloud-ddc-infra/eks.tf

henrykie · 2024-11-25T23:16:36Z

samples/unreal-cloud-ddc-single-region/main.tf

+      bucket_name = module.unreal_cloud_ddc_infra.s3_bucket_id
+    }),
+    templatefile("./assets/unreal_cloud_ddc_base.yaml", {
+      scylla_dns          = "scylla.example.com"


This is an internal private hosted zone created BY the module. I also see a problem with this in situations where networking is handled by a distinct account from the DDC deployment account (cross-account VPC hosted zone association)

henrykie · 2024-11-25T23:17:11Z

samples/unreal-cloud-ddc-single-region/main.tf

-      okta_domain         = var.okta_domain
-      okta_auth_server_id = var.okta_auth_server_id
-      jwt_audience        = var.jwt_audience
-      jwt_authority       = var.jwt_authority
+      okta_domain         = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["okta_domain"]
+      okta_auth_server_id = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["okta_auth_server_id"]
+      jwt_audience        = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["jwt_audience"]
+      jwt_authority       = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["jwt_authority"]


I am confused by this block.

henrykie · 2024-11-25T23:18:33Z

samples/unreal-cloud-ddc-single-region/main.tf

+      okta_domain         = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["okta_domain"]
+      okta_auth_server_id = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["okta_auth_server_id"]
+      jwt_audience        = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["jwt_audience"]
+      jwt_authority       = jsondecode(data.aws_secretsmanager_secret_version.current.secret_string)["jwt_authority"]
    }),
    file("./assets/unreal_cloud_ddc_values.yaml")


would rather see us use the Terraform path object

henrykie · 2024-11-25T23:18:49Z

samples/unreal-cloud-ddc-single-region/variables.tf

+variable "oidc_credential_arn" {
  type        = string
  sensitive   = true
-  description = "Okta Domain"
+  description = "OIDC Secrets Credential ARN"
 }


Better description and instructions for creating this secret

henrykie · 2024-11-25T23:19:17Z

samples/unreal-cloud-ddc-single-region/variables.tf

+variable "eks_cluster_ip_allow_list" {
  type        = list(string)
  default     = []
  description = "IPs that will be allow listed to access cluster over internet"


I think this should be managed externally. Cluster SG ID is output from the module. Rules are created at the sample level.

So this is so terraform can set up the eks cluster. if this is not enabled we have to have a server or bastion running in a private subnet which is hard to showcase with an example. Lets talk about how to fix this

modules/unreal/unreal-cloud-ddc-infra/eks.tf

+resource "aws_eks_cluster" "unreal_cloud_ddc_eks_cluster" {
+  #checkov:skip=CKV_AWS_39:This needs to be open to configure the eks cluster.
+  #checkov:skip=CKV_AWS_58:This will need to be enabled in a future update
+  #checkov:skip=CKV_AWS_38:IP restriction set in module variables
+  name                      = var.name
+  role_arn                  = aws_iam_role.eks_cluster_role.arn
+  version                   = var.kubernetes_version
+  enabled_cluster_log_types = ["api", "audit", "authenticator", "controllerManager", "scheduler"]
+
+
+
+  access_config {
+    authentication_mode                         = "API_AND_CONFIG_MAP"
+    bootstrap_cluster_creator_admin_permissions = true
+  }
+
+  vpc_config {
+    subnet_ids              = var.private_subnets
+    endpoint_private_access = true
+    endpoint_public_access  = true
+    public_access_cidrs     = var.eks_cluster_access_cidr
+    security_group_ids = [
+      aws_security_group.system_security_group.id,
+      aws_security_group.worker_security_group.id,
+      aws_security_group.nvme_security_group.id
+    ]
+  }
+}


modules/unreal/unreal-cloud-ddc-infra/eks.tf

+resource "aws_eks_cluster" "unreal_cloud_ddc_eks_cluster" {
+  #checkov:skip=CKV_AWS_39:This needs to be open to configure the eks cluster.
+  #checkov:skip=CKV_AWS_58:This will need to be enabled in a future update
+  #checkov:skip=CKV_AWS_38:IP restriction set in module variables
+  name                      = var.name
+  role_arn                  = aws_iam_role.eks_cluster_role.arn
+  version                   = var.kubernetes_version
+  enabled_cluster_log_types = ["api", "audit", "authenticator", "controllerManager", "scheduler"]
+
+
+
+  access_config {
+    authentication_mode                         = "API_AND_CONFIG_MAP"
+    bootstrap_cluster_creator_admin_permissions = true
+  }
+
+  vpc_config {
+    subnet_ids              = var.private_subnets
+    endpoint_private_access = true
+    endpoint_public_access  = true
+    public_access_cidrs     = var.eks_cluster_access_cidr
+    security_group_ids = [
+      aws_security_group.system_security_group.id,
+      aws_security_group.worker_security_group.id,
+      aws_security_group.nvme_security_group.id
+    ]
+  }
+}


modules/unreal/unreal-cloud-ddc-infra/eks.tf

+resource "aws_eks_cluster" "unreal_cloud_ddc_eks_cluster" {
+  #checkov:skip=CKV_AWS_39:This needs to be open to configure the eks cluster.
+  #checkov:skip=CKV_AWS_58:This will need to be enabled in a future update
+  #checkov:skip=CKV_AWS_38:IP restriction set in module variables
+  name                      = var.name
+  role_arn                  = aws_iam_role.eks_cluster_role.arn
+  version                   = var.kubernetes_version
+  enabled_cluster_log_types = ["api", "audit", "authenticator", "controllerManager", "scheduler"]
+
+
+
+  access_config {
+    authentication_mode                         = "API_AND_CONFIG_MAP"
+    bootstrap_cluster_creator_admin_permissions = true
+  }
+
+  vpc_config {
+    subnet_ids              = var.private_subnets
+    endpoint_private_access = true
+    endpoint_public_access  = true
+    public_access_cidrs     = var.eks_cluster_access_cidr
+    security_group_ids = [
+      aws_security_group.system_security_group.id,
+      aws_security_group.worker_security_group.id,
+      aws_security_group.nvme_security_group.id
+    ]
+  }
+}


modules/unreal/unreal-cloud-ddc-infra/s3.tf

+resource "aws_s3_bucket" "unreal_ddc_s3_bucket" {
+  #checkov:skip=CKV_AWS_21:Ensure all data stored in the S3 bucket have versioning enabled
+  #checkov:skip=CKV2_AWS_61:Ensure that an S3 bucket has a lifecycle configuration
+  #checkov:skip=CKV2_AWS_62:This bucket doesnt have any triggers needed as its only an object store
+  #checkov:skip=CKV_AWS_144:This bucket hosts ephemeral recreatable assets
+  #checkov:skip=CKV_AWS_18:Logging bucket cna be configured by customer
+  bucket_prefix = "${var.name}-s3-bucket"
+  force_destroy = true
+}


samples/unreal-cloud-ddc-single-region/vpc/main.tf

initial commit of unreal cloud ddc module and sample

35c11e1

danielw-aws requested a review from a team as a code owner October 3, 2024 16:35

danielw-aws requested a review from novekm October 3, 2024 16:35

github-advanced-security bot found potential problems Oct 3, 2024

View reviewed changes

jorisdon self-requested a review October 3, 2024 16:42

danielw-aws added 2 commits October 3, 2024 10:05

added a depends on to allow for correct sequence of destruction

c34c48e

Merge branch 'main' into danielw-aws/unreal-cloud-ddc

820b8bd

github-advanced-security bot found potential problems Oct 3, 2024

View reviewed changes

henrykie requested changes Oct 3, 2024

View reviewed changes

jorisdon reviewed Oct 4, 2024

View reviewed changes

gabebatista reviewed Oct 4, 2024

View reviewed changes

kylesomers requested changes Oct 15, 2024

View reviewed changes

danielw-aws added 2 commits October 17, 2024 11:09

fixed provider and github credential usage

78a05f2

started breaking apart main.tf into smaller sub-files and fixed check…

e9fe9d1

…ov comments

github-advanced-security bot found potential problems Oct 23, 2024

View reviewed changes

broke apart main files into smaller encapsulated files. need to fix p…

520b2a4

…arsing issue on sample

fixed regex for scylla and removed external dns. Added helm values fi…

ceda797

…les.

github-advanced-security bot found potential problems Nov 25, 2024

View reviewed changes

henrykie self-requested a review November 25, 2024 22:53

henrykie requested changes Nov 25, 2024

View reviewed changes

danielw-aws added 2 commits November 26, 2024 10:23

fixed checkov comment in vpc module

d7a6b39

fixed scylla replacment issue and update all checkov comments minus kms

c9b515c

github-advanced-security bot found potential problems Nov 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial commit of unreal cloud ddc module and sample #341

initial commit of unreal cloud ddc module and sample #341

danielw-aws commented Oct 3, 2024

github-advanced-security bot left a comment

henrykie left a comment

henrykie Oct 3, 2024

henrykie Oct 3, 2024

henrykie commented Oct 3, 2024

jorisdon Oct 4, 2024

jorisdon Oct 4, 2024

jorisdon Oct 4, 2024

jorisdon Oct 4, 2024

jorisdon Oct 4, 2024

henrykie Nov 25, 2024

gabebatista left a comment

gabebatista Oct 4, 2024

gabebatista Oct 4, 2024

gabebatista Oct 4, 2024

kylesomers left a comment •

edited

Loading

henrykie commented Nov 7, 2024

henrykie commented Nov 13, 2024

danielw-aws Nov 26, 2024

henrykie Nov 26, 2024

danielw-aws Nov 26, 2024

henrykie left a comment

henrykie Nov 25, 2024

henrykie Nov 25, 2024

danielw-aws Nov 26, 2024

henrykie Nov 25, 2024

henrykie Nov 25, 2024

henrykie Nov 25, 2024

henrykie Nov 25, 2024

henrykie Nov 25, 2024

danielw-aws Nov 26, 2024

		#checkov:skip=CKV2_AWS_38:Ensure Domain Name System Security Extensions (DNSSEC) signing is enabled for Amazon Route 53 public hosted zones
		#checkov:skip=CKV2_AWS_39:Ensure Domain Name System (DNS) query logging is enabled for Amazon Route 53 hosted zones

initial commit of unreal cloud ddc module and sample #341

Are you sure you want to change the base?

initial commit of unreal cloud ddc module and sample #341

Conversation

danielw-aws commented Oct 3, 2024

Summary

Changes

User experience

Checklist

Acknowledgment

github-advanced-security bot left a comment

Choose a reason for hiding this comment

henrykie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrykie commented Oct 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabebatista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kylesomers left a comment • edited Loading

Choose a reason for hiding this comment

henrykie commented Nov 7, 2024

henrykie commented Nov 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henrykie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kylesomers left a comment •

edited

Loading