Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tag names so that they match recommended best practices #343

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

jorisdon
Copy link
Contributor

@jorisdon jorisdon commented Oct 4, 2024

Issue number: N/A

Summary

Changes

This changes the predefined, default tag names such that they match recommended best practices (all lowercase, hyphens to separate words)

User experience

No changes in user experience

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change? Depends. Not traditionally, but if users have applied their own logic to the predefined tags, or if they have applied cost categories, then these may need to be altered, or users may want to explicitly define the defaults that were used previously.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

Sorry, something went wrong.

@jorisdon jorisdon requested a review from a team as a code owner October 4, 2024 14:47
@jorisdon jorisdon requested a review from gabebatista October 4, 2024 14:47
henrykie
henrykie previously approved these changes Oct 4, 2024
gabebatista
gabebatista previously approved these changes Oct 4, 2024
Copy link
Contributor

@gabebatista gabebatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorisdon jorisdon dismissed stale reviews from gabebatista and henrykie via 3285e95 October 7, 2024 09:14
@jorisdon jorisdon force-pushed the jorisdon/fix-tag-names branch from 90be0cb to 3285e95 Compare October 7, 2024 09:14
Copy link
Contributor

@gabebatista gabebatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorisdon jorisdon merged commit e7cf94e into main Oct 7, 2024
7 checks passed
@jorisdon jorisdon deleted the jorisdon/fix-tag-names branch October 7, 2024 14:39
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants