chore: define nat gateway routes outside of aws_route_table resources in samples and modules #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samples and modules
henrykie
approved these changes
Oct 9, 2024
jcwolfaws
pushed a commit
to jcwolfaws/cloud-game-development-toolkit
that referenced
this pull request
Dec 10, 2024
…aws_route_table resources in samples and modules (aws-games#354)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
Summary
Changes
This change ensures that the NAT Gateway routes for private route tables are declared in
aws_routeresources, instead of through theaws_route_tableresource that creates the route table. The rationale for this is that the way it's done now does not allow users to add their own routes to these route tables outside of theaws_route_tableresource's route declarations.User experience
Users that are basing their infrastructure off of the samples and have their own routes defined for the private route tables will no longer see their additions getting removed by Terraform incorrectly.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
I have tested the changes for the Horde sample.
No changes in documentation are necessary.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.