-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gabeaws/docs/getting started updates #357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabebatista
added
documentation
Improvements or additions to documentation
samples
Updates to project samples
packer
Work related to Packer templates
labels
Oct 10, 2024
1 task
closes #355 @gabebatista ? |
henrykie
previously approved these changes
Oct 10, 2024
henrykie
force-pushed
the
gabeaws/docs/getting-started-updates
branch
from
October 14, 2024 16:07
e98d05c
to
907db37
Compare
kylesomers
approved these changes
Oct 14, 2024
kylesomers
previously requested changes
Oct 14, 2024
gabebatista
force-pushed
the
gabeaws/docs/getting-started-updates
branch
from
October 16, 2024 21:26
907db37
to
ad07d47
Compare
jorisdon
approved these changes
Oct 18, 2024
henrykie
approved these changes
Oct 18, 2024
gabebatista
force-pushed
the
gabeaws/docs/getting-started-updates
branch
from
October 18, 2024 18:05
ad07d47
to
bb22428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
packer
Work related to Packer templates
samples
Updates to project samples
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #355
Summary
Updates documentation for getting started with the simple build pipeline sample and adds missing defaults packer template.
Changes
us-west-2
and can cause errors.Note
admonition in theAmazon Linux 2023 ARM based Amazon Machine Image
section to a warning, as not heading that admonition would cause the command to fail.vpc_id
andsubnet_id
variables inamazon-linux-2023-arm64.pkr.hcl
, allowing Packer to default to the default VPC if no value is passed in.fully_qualified_domain_name
reference inStep 5. Configure Simple Build Pipeline Variables
toroot_domain_name
to align with name change in code.Step 5. Configure Simple Build Pipeline Variables
section intolocal.tf
andvariables.tf
paragraphs to align with module structure.User experience
Fixes faulty code and clarifies sections which are most likely to cause issues for users.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.