Perforce: resolve #301 #378
Conversation
|
@GrzesiekO please rebase the base branch onto this feature branch, and potentially consider renaming / squashing your second commit so that both use conventional commit structure. |
|
@GrzesiekO You want to update and merge? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jorisdon
force-pushed
the
ochmang-helixcore-improvments
branch
4 times, most recently
from
56fe076 to
acabc6b
Compare
jorisdon
changed the title
jorisdon
changed the title
assets/ansible-playbooks/perforce/helix-core/p4_configure_playbook.yml
Outdated
Show resolved
Hide resolved
|
I am not entirely sure how this Ansible playbook and the Packer template are supposed to be used. Do we expect users to build the Perforce AMI via Packer (which loads |
|
+1. I was under the impression we were eventually replacing |
GrzesiekO
changed the title
|
To clarify on the answer to my previous question:
The Ansible playbook was incomplete / not fully usable yet, and we've decided to remove it to allow the pull request to proceed. |
…ting security groups The main Terraform module has been updated to allow adding existing security groups without creating a default one. This fixes an issue where the module was creating a new security group even when one was already provided. Additionally, the core module has been enhanced to provide Unicode support, enabling expanded character set handling. Other minor fixes and cleanup. chore: fix typo
- Replace p4_configure.sh and p4_setup.sh with Ansible playbook - Eliminate need for Packer-built AMI and automates Amazon Linux 2023 - Add tasks for downloading and configuring Helix binaries - Implement platform-specific binary selection - Ensure correct placement of binaries in /hxdepots/sdp/helix_binaries - Add error handling and retries for binary downloads - Improve automation and consistency in Perforce Helix Core setup This playbook automates the Perforce Helix Core installation and configuration process, providing a more robust and maintainable solution compared to the previous shell scripts. It dynamically selects the appropriate binaries based on the target system's architecture, enhancing cross-platform compatibility. This also adds an SSM document for Helix Core configuration - Create new SSM module for applying Ansible playbooks - Update p4_configure_playbook.yml with improved installation steps - Modify p4_configure.sh remove unecessary selinux commands This commit introduces an SSM document to streamline the deployment of Perforce Helix Core on EC2 instances using Ansible playbooks. The configuration process is now more automated and consistent across deployments.
…book.yml Deleting as not vital for this PR.
chore: remove unused file Deleted ssm_module.tf as it was no longer needed in the project. This file removal doesn't affect any functionality.
henrykie
force-pushed
the
ochmang-helixcore-improvments
branch
from
27028b9 to
d6c6d8f
Compare
Issue number:
#301
Summary
This PR fixes and improves a few things:
p4_configure.shrun #301)Changes
Minor fixes in p4_configure.sh
New variables in the p4_configure.sh script:
--unicodeand--selinux. These are also set by Terraform in the EC2 userdata that invokes the p4_configure.sh script. In Terraform, they both default to "false"User experience
New variable in Terraform for helix-core module "unicode" to address unicode mode in Helix Core.
New variable in Terraform for helix-core module "selinux" to make updating SElinux labels optional depending on underlying OS used.
Both default to false.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No it is not a breaking change it fixes minor bugs and adds one core requested funcitonalityAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.