Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added service target group ARNs as outputs for HAS and Swarm #391

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

henrykie
Copy link
Contributor

Issue number:
N/A

Summary

Small fix to expose ECS service target groups as outputs for Helix Swarm and Helix Core.

Changes

Please provide a summary of what's being changed

  • Added Helix Swarm target group output: target_group_arn
  • Added Helix Authentication Service target group output: target_group_arn

User experience

Please share what the user experience looks like before and after this change

Users looking to share an application load balancer across services can now leverage the output target groups to forward traffic to the underlying services.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@henrykie henrykie added perforce terraform Pull requests that update Terraform code labels Nov 18, 2024
@henrykie henrykie self-assigned this Nov 18, 2024
@henrykie henrykie requested a review from a team as a code owner November 18, 2024 20:07
@henrykie henrykie requested a review from danielw-aws November 18, 2024 20:07
@henrykie henrykie force-pushed the henrykie/perforce/load-balancers branch from 33b01c9 to 89a492e Compare November 18, 2024 20:09
@jorisdon jorisdon self-requested a review November 21, 2024 13:50
@jorisdon jorisdon force-pushed the henrykie/perforce/load-balancers branch from 89a492e to 3809e03 Compare November 22, 2024 10:34
@jorisdon jorisdon merged commit b39ef46 into main Nov 22, 2024
5 checks passed
@jorisdon jorisdon deleted the henrykie/perforce/load-balancers branch November 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perforce terraform Pull requests that update Terraform code
Projects
Development

Successfully merging this pull request may close these issues.

3 participants