Delegate file not found error to caller #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AniruddhaKanhere
requested changes
Dec 19, 2024
| @@ -488,9 +488,6 @@ GglError ggl_file_read_path_at(int dirfd, GglBuffer path, GglBuffer *content) { | |||
| int fd; | |||
| GglError ret = ggl_file_openat(dirfd, path, O_RDONLY, 0, &fd); | |||
| if (ret != GGL_ERR_OK) { | |||
| GGL_LOGD( | |||
There was a problem hiding this comment.
Why did we remove this?
Since this failed and we exit here, I suggest we make it an error log.
There was a problem hiding this comment.
This needs to be a Error not a debug
There was a problem hiding this comment.
So why did we not make it an error log?
Delegate file not found error to caller
AniruddhaKanhere
requested changes
Dec 19, 2024
AniruddhaKanhere
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.